Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chai 3.4.0 #10

Closed
SteveEdson opened this issue Oct 21, 2015 · 12 comments
Closed

Chai 3.4.0 #10

SteveEdson opened this issue Oct 21, 2015 · 12 comments

Comments

@SteveEdson
Copy link

Any chance this could be updated to work with Chai 3.4.0 please?

Thanks

@scheibinger
Copy link

👍

1 similar comment
@yoannmoinet
Copy link

👍

@mmun
Copy link

mmun commented Dec 26, 2015

What's wrong? It seems to be working for me with [email protected], other than this warning:

npm WARN [email protected] requires a peer of chai@>= 1.6.1 < 2 but none was installed.

@dmartin-gh
Copy link

It may technically work with Chai 3, but unless the peer dependency is fixed that warning becomes an error for npm shrinkwrap:

npm ERR! Linux 3.10.0-327.3.1.el7.x86_64
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "shrinkwrap" "--dev"
npm ERR! node v5.4.0
npm ERR! npm  v3.5.3

npm ERR! Problems were encountered
npm ERR! Please correct and try again.
npm ERR! peer invalid: chai@>= 1.6.1 < 2, required by [email protected]
npm ERR! 
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

@jhnns
Copy link

jhnns commented Jan 24, 2016

I don't know if all assertions are working, but in my setup chai-fs is working just fine. Would be good to get rid of the peer dependency warning. 👍

@jhnns
Copy link

jhnns commented Jan 25, 2016

Btw: It's also a problem because CI builds are failing just because npm install exits with an error code. So it's not just a cosmetic problem.

jhnns added a commit to peerigon/extract-loader that referenced this issue Jan 25, 2016
mearns added a commit to mearns/chai-fs that referenced this issue Apr 5, 2016
mearns added a commit to mearns/chai-fs that referenced this issue Apr 5, 2016
Issue chaijs#10 - Update Chai Version
@Bartvds
Copy link
Contributor

Bartvds commented Apr 7, 2016

Sorry guys, I've crashed out of the loop on node and have no idea what is current on npm and node. At this point I cannot push to npm at the risk of nuking whoever still has this working.

I think someone who knows what they are doing should take ownership, sort this out and be a better steward.

If one (or more) of you are up for it please coordinate between you all, send me your npm and github handles and I will transfer repos and npm ownership soonest.

@Bartvds
Copy link
Contributor

Bartvds commented Apr 7, 2016

Quick update: @keithamus offered to adopt this module in the Chaijs organisation. Probably the ideal solution so we're proceeding on that right now.

@SteveEdson
Copy link
Author

Excellent news for everyone, thanks. Thanks for all the work @Bartvds 👍

@jhnns
Copy link

jhnns commented Apr 8, 2016

@Bartvds @keithamus thank you!

@meeber
Copy link

meeber commented Jun 5, 2016

I think this was resolved via #8. Can we close this? @keithamus

@keithamus
Copy link
Member

We can. There is some work to do to release this though. It's on my to-do list 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants