Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs/admin: Rename fs quiesce test file #990

Merged
merged 1 commit into from
May 30, 2024

Conversation

anoopcs9
Copy link
Collaborator

We do have a test file named fs_quiesce_reef_test.go to make sure that the feature is supported only from upcoming squid release. The reef keyword doesn't make sense as the test itself is applicable for any version prior to squid(upcoming). Therefore use a generic unsupported keyword in the test file name.

We do have a test file named fs_quiesce_reef_test.go to make sure
that the feature is supported only from upcoming squid release. The
'reef' keyword doesn't make sense as the test itself is applicable
for any version prior to squid(upcoming). Therefore use a generic
'unsupported' keyword in the test file name.

Signed-off-by: Anoop C S <[email protected]>
@anoopcs9 anoopcs9 requested a review from phlogistonjohn May 30, 2024 07:56
@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label May 30, 2024
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me.

@mergify mergify bot merged commit 2b9a021 into ceph:master May 30, 2024
16 checks passed
@anoopcs9 anoopcs9 deleted the rename-fs-quiesce-test-file branch May 30, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants