Quiesce test failing for pre-squid

[phlogistonjohn]

Possibly due to the new feature being backported to squid branch:

 === RUN   TestFSQuiesce
    fs_quiesce_reef_test.go:22: 
        	Error Trace:	/go/src/github.com/ceph/go-ceph/cephfs/admin/fs_quiesce_reef_test.go:22
        	Error:      	Expected nil, but got: &admin.FSQuiesceInfo{Epoch:5, SetVersion:1, Sets:map[string]admin.QuiesceInfo{"ac47ac80":admin.QuiesceInfo{Version:1, AgeRef:0, State:admin.QuiesceState{Name:"TIMEDOUT", Age:0}, Timeout:0, Expiration:0, Members:map[string]admin.QuiesceInfoMember{"file:/volumes/_nogroup/quiesceMe/bf7b4f2b-e605-40f0-8103-4b7f692440ad":admin.QuiesceInfoMember{Excluded:false, State:admin.QuiesceState{Name:"QUIESCING", Age:0}}}}}}
        	Test:       	TestFSQuiesce
    fs_quiesce_reef_test.go:24: 
        	Error Trace:	/go/src/github.com/ceph/go-ceph/cephfs/admin/fs_quiesce_reef_test.go:24
        	Error:      	Should be true
        	Test:       	TestFSQuiesce
--- FAIL: TestFSQuiesce (0.09s)
=== RUN   TestServerSentinel

https://github.com/ceph/go-ceph/actions/runs/8398382664/job/23003150402

[phlogistonjohn]

cc: @manishym @nixpanic @anoopcs9

[anoopcs9]

We all knew this was coming and that's exactly why I requested for an issue early on to track the changes required with the build tags for 2 variants of test files(fs_quiesce_test.go and fs_quiesce_reef_test.go).

Let's keep the issue open until squid release is out with the feature and corresponding CI job is enabled for go-ceph.

Till then we could have the following change in build tags:

index 5a1075c..73e28ff 100644
--- a/cephfs/admin/fs_quiesce_reef_test.go
+++ b/cephfs/admin/fs_quiesce_reef_test.go
@@ -1,4 +1,4 @@
-//go:build (nautilus || octopus || pacific || quincy || reef || squid || ceph_pre_squid) && ceph_preview
+//go:build (nautilus || octopus || pacific || quincy || reef) && ceph_preview
 
 package admin
 
diff --git a/cephfs/admin/fs_quiesce_test.go b/cephfs/admin/fs_quiesce_test.go
index db2d94d..4aa4b05 100644
--- a/cephfs/admin/fs_quiesce_test.go
+++ b/cephfs/admin/fs_quiesce_test.go
@@ -1,4 +1,4 @@
-//go:build !(nautilus || octopus || pacific || quincy || reef || squid || ceph_pre_squid) && ceph_preview
+//go:build !(nautilus || octopus || pacific || quincy || reef) && ceph_preview
 
 package admin

I would also suggest a change in name for fs_quiesce_reef_test.go as it is applicable for any version prior to squid(upcoming).

[anoopcs9]

I would also suggest a change in name for fs_quiesce_reef_test.go as it is applicable for any version prior to squid(upcoming).

Created #990 to address the ambiguity in test file name.

[anoopcs9]

I can confirm that the test TestFSQuiesce from fs_quiesce_test.go is passing with #1012. Thus we no longer require any build tag changes.