Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: Add futimens cephfs API #874

Merged
merged 1 commit into from
May 12, 2023
Merged

cephfs: Add futimens cephfs API #874

merged 1 commit into from
May 12, 2023

Conversation

Nikhil-Ladha
Copy link
Contributor

Added a new cephfs API named ceph_futimens

Fixes: #253

Signed-off-by: Nikhil-Ladha [email protected]

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

@Nikhil-Ladha Nikhil-Ladha force-pushed the issue253/ceph_futimens branch from 208c3a0 to c551040 Compare April 25, 2023 11:38
phlogistonjohn
phlogistonjohn requested changes Apr 27, 2023
View reviewed changes
cephfs/file_ops.go Outdated Show resolved Hide resolved
@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Apr 28, 2023
@Nikhil-Ladha Nikhil-Ladha force-pushed the issue253/ceph_futimens branch from c551040 to 5aa3b5e Compare April 28, 2023 13:40
@Nikhil-Ladha Nikhil-Ladha force-pushed the issue253/ceph_futimens branch from 5aa3b5e to 1a8f8f5 Compare May 2, 2023 16:23
@phlogistonjohn phlogistonjohn mentioned this pull request May 3, 2023
Merged
5 tasks
@phlogistonjohn
Copy link
Collaborator

@Mergifyio rebase

@Nikhil-Ladha @phlogistonjohn
cephfs: Add futimens cephfs API
8804379 
Added a new cephfs API named `ceph_futimens`

Fixes: ceph#253

Signed-off-by: Nikhil-Ladha <[email protected]>
@mergify
Copy link

mergify bot commented May 8, 2023

rebase

✅ Branch has been successfully rebased

@phlogistonjohn phlogistonjohn force-pushed the issue253/ceph_futimens branch from 1a8f8f5 to 8804379 Compare May 8, 2023 13:51
phlogistonjohn
phlogistonjohn approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@phlogistonjohn phlogistonjohn requested review from anoopcs9 and ansiwen May 8, 2023 13:52
anoopcs9
anoopcs9 approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@mergify mergify bot merged commit 39336da into ceph:master May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

@anoopcs9 anoopcs9 anoopcs9 approved these changes

@ansiwen ansiwen Awaiting requested review from ansiwen

Assignees
No one assigned
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing cephfs API components: function ceph_futimens
3 participants
@Nikhil-Ladha @phlogistonjohn @anoopcs9