Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs: Add futimes cephfs API #875

Merged
merged 1 commit into from
May 18, 2023

Conversation

Nikhil-Ladha
Copy link
Contributor

Added a new cephfs API named ceph_futimes

Fixes: #254

Signed-off-by: Nikhil-Ladha [email protected]

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Apr 28, 2023
@Nikhil-Ladha Nikhil-Ladha force-pushed the issue254/ceph_futimes branch from 34fd3e4 to daa5d52 Compare May 2, 2023 16:23
cephfs/file_ops.go Outdated Show resolved Hide resolved
@Nikhil-Ladha Nikhil-Ladha force-pushed the issue254/ceph_futimes branch from daa5d52 to 88f56c2 Compare May 3, 2023 14:42
@Nikhil-Ladha
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented May 9, 2023

rebase

❌ Unable to rebase: user Nikhil-Ladha is unknown.

Please make sure Nikhil-Ladha has logged in Mergify dashboard.

@Nikhil-Ladha
Copy link
Contributor Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented May 9, 2023

rebase

❌ Base branch update has failed

Nikhil-Ladha token is invalid, make sure Nikhil-Ladha can still log in on the Mergify dashboard.
err-code: 3DCA0

@Nikhil-Ladha Nikhil-Ladha force-pushed the issue254/ceph_futimes branch from 88f56c2 to 33ad42a Compare May 9, 2023 09:07
@mergify
Copy link

mergify bot commented May 12, 2023

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

@Nikhil-Ladha Nikhil-Ladha force-pushed the issue254/ceph_futimes branch from 33ad42a to 0b2c98f Compare May 12, 2023 11:04
@Nikhil-Ladha
Copy link
Contributor Author

Awaiting review @phlogistonjohn and @anoopcs9 😅

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Added a new cephfs API named `ceph_futimes`

Fixes: ceph#254

Signed-off-by: Nikhil-Ladha <[email protected]>
@Nikhil-Ladha Nikhil-Ladha force-pushed the issue254/ceph_futimes branch from 0b2c98f to 3dec8b9 Compare May 18, 2023 06:41
@mergify mergify bot merged commit 15ede44 into ceph:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API This PR includes a change to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing cephfs API components: function ceph_futimes
3 participants