feat: Adds validator qgb checks tests #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
changed the title
…ecks # Conflicts: # client/flags/flags.go # simapp/simd/cmd/testnet.go # x/staking/simulation/operations.go
…mulation to have a deterministic way of creating it
…ecks_tests # Conflicts: # x/staking/keeper/msg_server.go # x/staking/simulation/operations.go
rach-id
changed the title
evan-forbes
approved these changes
May 9, 2022
There was a problem hiding this comment.
mostly simple additions! 👍 utACK
I'm slightly concerned about upgrading a chain to use the QGB module and this change, as we'd either have to pass some address similar to the zero address, or have all of the validators eth address/orchestrator address ahead of time before upgrading.
You're right. But I thought that we will have some migration script that would change the state without depending on messages to do state transitions. If it is not, then I should change. |
|
Yeah, we can have an upgrade handler do whatever we need without getting that info ahead of time. I'm still worried about it though, at least until we can test upgrade, as having fake addresses as placeholders seems super hacky. |
|
@evan-forbes So should I remove the zero address check ? until we decide ? |
|
nah, let's keep it. After we get mvp working on an integration test, then we'll plan out the upgrade then |
|
Merging then? |
|
Just renamed the branch we're targeting to: release/v0.44.x-celestia-qgb. I will make sure it will always have the latest celestia branch changes (hopefuly). Then, we merge it to the default branch once we decide to merge QGB module to celestia-app. |
|
sounds good 👍 |
rach-id
added a commit
to rach-id/cosmos-sdk
that referenced
this pull request
May 9, 2022
* first pass on tests fixes * fixes the rest of unit tests * remove unnecessary comments * uses default eth address when starting sim network * cosmetics * comments failing test * comments failing test * adds orchestrator/ethereum address checks for validators when creating and editing * uses correct error codes for eth/orch address errors * uncomments test and fixes it from commit 434b308 * updates tests to be able to set orch/eth address when creating validators * adds zero eth address check when creating/updating validator * attempts to fix duplicate eth address in sim network * adds validator check tests * revert squashed changes * uses unwrapped context for msg_server orch/eth validation * increase DefaultGenTxGas to accomodate new qgb validator changes * scaffolds an ethereum address from orchestrator address in staking simulation to have a deterministic way of creating it * fix eth address creation from orch address in operations * increase DefaultGenTxGas * increase DefaultGenTxGas * remove unnecessary eth address
rach-id
added a commit
to rach-id/cosmos-sdk
that referenced
this pull request
Jul 27, 2022
* first pass on tests fixes * fixes the rest of unit tests * remove unnecessary comments * uses default eth address when starting sim network * cosmetics * comments failing test * comments failing test * adds orchestrator/ethereum address checks for validators when creating and editing * uses correct error codes for eth/orch address errors * uncomments test and fixes it from commit 434b308 * updates tests to be able to set orch/eth address when creating validators * adds zero eth address check when creating/updating validator * attempts to fix duplicate eth address in sim network * adds validator check tests * revert squashed changes * uses unwrapped context for msg_server orch/eth validation * increase DefaultGenTxGas to accomodate new qgb validator changes * scaffolds an ethereum address from orchestrator address in staking simulation to have a deterministic way of creating it * fix eth address creation from orch address in operations * increase DefaultGenTxGas * increase DefaultGenTxGas * remove unnecessary eth address
rach-id
added a commit
to rach-id/cosmos-sdk
that referenced
this pull request
Aug 4, 2022
* first pass on tests fixes * fixes the rest of unit tests * remove unnecessary comments * uses default eth address when starting sim network * cosmetics * comments failing test * comments failing test * adds orchestrator/ethereum address checks for validators when creating and editing * uses correct error codes for eth/orch address errors * uncomments test and fixes it from commit 434b308 * updates tests to be able to set orch/eth address when creating validators * adds zero eth address check when creating/updating validator * attempts to fix duplicate eth address in sim network * adds validator check tests * revert squashed changes * uses unwrapped context for msg_server orch/eth validation * increase DefaultGenTxGas to accomodate new qgb validator changes * scaffolds an ethereum address from orchestrator address in staking simulation to have a deterministic way of creating it * fix eth address creation from orch address in operations * increase DefaultGenTxGas * increase DefaultGenTxGas * remove unnecessary eth address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to #114