Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks/tests to the newly added orchestrator/Ethereum addresses to the staking module #114

Closed
Tracked by #301
rach-id opened this issue Apr 13, 2022 · 3 comments
Assignees
Labels
C: QGB enhancement New feature or request

Comments

@rach-id
Copy link
Member

rach-id commented Apr 13, 2022

Currently, following the development under the #112 branch, we are adding two fields to the Validator struct for the staking module: EthereumAddress and OrchestratorAddress.
We will need to update the functionality and also add tests to support the new changes, check for the conditions defined below and also create new tests suits that would check for the following:

When creating a new validator

  • The provided Orchestrator address is valid and not a duplicate (no previous validator uses the same orchestrator address)
  • The provided Ethereum address is valid and not a duplicate (no previous validator uses the same Ethereum address)
  • The provided Ethereum address is not the zero address

When editing a validator

  • Same as the previous
@adlerjohn
Copy link
Member

Once your branch is deleted after the PR is merged, that link will be dangling. Can you link to the PR proper?

@rach-id
Copy link
Member Author

rach-id commented Apr 13, 2022

Sure

@rach-id rach-id changed the title Add functionality/tests to the newly added orchestrator/Ethereum addresses to the staking module Add cheks/tests to the newly added orchestrator/Ethereum addresses to the staking module Apr 13, 2022
@adlerjohn adlerjohn changed the title Add cheks/tests to the newly added orchestrator/Ethereum addresses to the staking module Add checks/tests to the newly added orchestrator/Ethereum addresses to the staking module Apr 13, 2022
@rach-id
Copy link
Member Author

rach-id commented Apr 20, 2022

Also, investigate if we need a separate orchestrator address field in a validator struct or the validator address is enough.

Edit: It is not, we can have separate addresses.

@rach-id rach-id self-assigned this May 5, 2022
@rach-id rach-id added C: QGB enhancement New feature or request labels May 5, 2022
@rach-id rach-id moved this from TODO to In Progress in Celestia Node May 5, 2022
@rach-id rach-id moved this from In Progress to In Review in Celestia Node May 9, 2022
@rach-id rach-id moved this from In Review to Done in Celestia Node May 9, 2022
@rach-id rach-id closed this as completed May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: QGB enhancement New feature or request
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants