-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump core to 1.1.0 #118
Conversation
Meh, |
looks like the liveness test is failing without libleopard
do we want to fix that before merging? I can look into it a few hours from now if so if we have an issue for it I'm fine with approving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to fix this before merging but I won't have time to look I to this in the next two days. |
I do not really understand why the liveness tests try to build go-leopard. Everything else worked after switching to go1.17 (which the liveness tests use as well). |
Just saw that @adlerjohn dismissed his review. The thing I've mentioned above is fixed in 0fa3271. |
I dismissed my review because CI is still failing |
unrelated flaky test which passed before and also on push to master. |
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change