Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump core to 1.1.0 #118

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Apr 18, 2022

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@liamsi liamsi requested a review from evan-forbes as a code owner April 18, 2022 22:38
@liamsi liamsi changed the title bump core to 1.1.0 chore: bump core to 1.1.0 Apr 18, 2022
@liamsi
Copy link
Member Author

liamsi commented Apr 18, 2022

Meh, Error: ../../../go/pkg/mod/github.com/celestiaorg/[email protected]/types/share_merging.go:8:2: //go:build comment without // +build comment. Maybe we should just have kept the // +build part in rsmt2d @adlerjohn. I'll bump to go 1.17 here as well.

@evan-forbes
Copy link
Member

evan-forbes commented Apr 19, 2022

looks like the liveness test is failing without libleopard

Status: Downloaded newer image for cosmossdk/rbuilder:latest
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
rm -rf \
    /tmp/tmp.m7HhfJWrhx/buildsources/build/ \
    artifacts/ \
    tmp-swagger-gen/
Building for linux/amd64
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
mkdir -p /tmp/tmp.m7HhfJWrhx/buildsources/build/
go build -mod=readonly -tags "netgo" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=sim -X github.com/cosmos/cosmos-sdk/version.AppName=simd -X github.com/cosmos/cosmos-sdk/version.Version=74[96](https://github.com/celestiaorg/cosmos-sdk/runs/6072165026?check_suite_focus=true#step:5:96)5660f -X github.com/cosmos/cosmos-sdk/version.Commit=74965660f23ff14e1302232ade0db39cf26cc3eb -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo" -X github.com/tendermint/tendermint/version.TMCoreSemVer=v1.1.0-tm-v0.34.16 -w -s -buildid=74965660f' -trimpath -o /tmp/tmp.m7HhfJWrhx/buildsources/build/ ./...
# github.com/celestiaorg/go-leopard/leopard
/usr/bin/ld: cannot find -llibleopard
/usr/bin/ld: cannot find -llibleopard
/usr/bin/ld: cannot find -llibleopard
/usr/bin/ld: cannot find -llibleopard

do we want to fix that before merging? I can look into it a few hours from now if so

if we have an issue for it I'm fine with approving

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#119

I should have time to dig into #119 later today, so I'm pre-approving

@liamsi
Copy link
Member Author

liamsi commented Apr 20, 2022

Would be good to fix this before merging but I won't have time to look I to this in the next two days.

@adlerjohn adlerjohn added the dependencies Pull requests that update a dependency file label Apr 20, 2022
adlerjohn
adlerjohn previously approved these changes Apr 20, 2022
@liamsi
Copy link
Member Author

liamsi commented Apr 20, 2022

I do not really understand why the liveness tests try to build go-leopard. Everything else worked after switching to go1.17 (which the liveness tests use as well).

@liamsi
Copy link
Member Author

liamsi commented Apr 20, 2022

cosmos#10385

@liamsi liamsi merged commit eee26c3 into release/v0.44.x-celestia Apr 20, 2022
@liamsi liamsi deleted the liamsi/bump-core-to-v1.1.0 branch April 20, 2022 20:33
@liamsi
Copy link
Member Author

liamsi commented Apr 20, 2022

hmm

Just saw that @adlerjohn dismissed his review. The thing I've mentioned above is fixed in 0fa3271.

@adlerjohn
Copy link
Member

I dismissed my review because CI is still failing

@liamsi
Copy link
Member Author

liamsi commented Apr 20, 2022

unrelated flaky test which passed before and also on push to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants