Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: liveness test doesn't seem to be using Go1.16+ hence doesn't compile #10385

Closed
3 of 4 tasks
odeke-em opened this issue Oct 16, 2021 · 3 comments · Fixed by #10396
Closed
3 of 4 tasks

ci: liveness test doesn't seem to be using Go1.16+ hence doesn't compile #10385

odeke-em opened this issue Oct 16, 2021 · 3 comments · Fixed by #10396
Assignees

Comments

@odeke-em
Copy link
Collaborator

Noticed from all these failures on the master branch
Screen Shot 2021-10-16 at 12 12 49 PM

for example https://github.com/cosmos/cosmos-sdk/runs/3905217253 which says

Status: Downloaded newer image for cosmossdk/rbuilder:latest
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
rm -rf \
    /tmp/tmp.ua3W2PiJsq/buildsources/build/ \
    artifacts/ \
    tmp-swagger-gen/
Building for linux/amd64
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
mkdir -p /tmp/tmp.ua3W2PiJsq/buildsources/build/
go build -mod=readonly -tags "netgo" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=sim -X github.com/cosmos/cosmos-sdk/version.AppName=simd -X github.com/cosmos/cosmos-sdk/version.Version=717dcdfa8 -X github.com/cosmos/cosmos-sdk/version.Commit=717dcdfa8f86133a159617abb8ec9ea41857f7d1 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo" -X github.com/tendermint/tendermint/version.TMCoreSemVer=v0.34.13 -w -s -buildid=717dcdfa8' -trimpath -o /tmp/tmp.ua3W2PiJsq/buildsources/build/ ./...
# github.com/cosmos/cosmos-sdk/snapshots
snapshots/manager.go:146:9: undefined: io.ReadAll
snapshots/manager.go:241:17: undefined: io.NopCloser
note: module requires Go 1.17
# github.com/cosmos/cosmos-sdk/crypto/keyring
crypto/keyring/keyring.go:684:19: undefined: os.ReadFile
crypto/keyring/keyring.go:748:14: undefined: os.WriteFile
note: module requires Go 1.17
# github.com/cosmos/cosmos-sdk/server/grpc/gogoreflection
server/grpc/gogoreflection/serverreflection.go:221:14: undefined: io.ReadAll
note: module requires Go 1.17
# github.com/cosmos/cosmos-sdk/codec/unknownproto
codec/unknownproto/unknown_fields.go:361:20: undefined: io.ReadAll
note: module requires Go 1.17
make: *** [Makefile:115: build] Error 2
make: *** [Makefile:133: build-simd-linux] Error 2
Error: Process completed with exit code 2.

You'll see that it can't recognize io.ReadAll, io.NopCloser of which these were introduced in Go1.16 https://pkg.go.dev/io#ReadAll and I was one of the folks that worked on them; seems like code in here must be using Go1.15. This started in #10341

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093
Copy link
Contributor

I also had a quick look a couple of days ago, IMO this would help: tendermint/images#73 (comment)

@tac0turtle
Copy link
Member

I may be looking in the wrong place, but i dont see this image being used?

@amaury1093
Copy link
Contributor

liveness-test on CI calls make clean build-simd-linux localnet-start, then

--name latest-build cosmossdk/rbuilder:latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants