Add nullability annotations to LazyHeaders.Builder functions #3446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
@NonNull
and@Nullable
annotations toLazyHeaders.Builder
andStringHeaderFactory
. When there is a possibility of null, a warning is displayed on the IDE and bug entry can be prevented.Motivation and Context
StringHeaderFactory
doesn't allow nullvalue
andLazyHeaders.Builder.addHeader(String key, String value)
also doesn't allow nullvalue
. However, the user can not know this spec unless they actually read the code.