Add nullability annotations to LazyHeaders.Builder functions

bumptech · Dec 7, 2018 · d47358d · d47358d
1 parent f7d8604
commit d47358d
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/library/src/main/java/com/bumptech/glide/load/model/LazyHeaders.java b/library/src/main/java/com/bumptech/glide/load/model/LazyHeaders.java
@@ -1,6 +1,7 @@
 package com.bumptech.glide.load.model;
 
 import android.support.annotation.NonNull;
+import android.support.annotation.Nullable;
 import android.support.annotation.VisibleForTesting;
 import android.text.TextUtils;
 import java.util.ArrayList;
@@ -132,7 +133,7 @@ public static final class Builder {
      *
      * @see #addHeader(String, LazyHeaderFactory)
      */
-    public Builder addHeader(String key, String value) {
+    public Builder addHeader(@NonNull String key, @NonNull String value) {
       return addHeader(key, new StringHeaderFactory(value));
     }
 
@@ -146,7 +147,7 @@ public Builder addHeader(String key, String value) {
      * <p> This class does not prevent you from adding the same value to a given key multiple
      * times </p>
      */
-    public Builder addHeader(String key, LazyHeaderFactory factory) {
+    public Builder addHeader(@NonNull String key, @Nullable LazyHeaderFactory factory) {
       if (isUserAgentDefault && USER_AGENT_HEADER.equalsIgnoreCase(key)) {
         return setHeader(key, factory);
       }
@@ -166,7 +167,7 @@ public Builder addHeader(String key, LazyHeaderFactory factory) {
      * (i.e. an OAuth token). </p>
      */
     @SuppressWarnings({"UnusedReturnValue", "WeakerAccess"}) // Public API
-    public Builder setHeader(String key, String value) {
+    public Builder setHeader(@NonNull String key, @Nullable String value) {
       return setHeader(key, value == null ? null : new StringHeaderFactory(value));
     }
 
@@ -176,7 +177,7 @@ public Builder setHeader(String key, String value) {
      *
      * <p> If the given value is {@code null}, the header at the given key will be removed. </p>
      */
-    public Builder setHeader(String key, LazyHeaderFactory factory) {
+    public Builder setHeader(@NonNull String key, @Nullable LazyHeaderFactory factory) {
       copyIfNecessary();
       if (factory == null) {
         headers.remove(key);
@@ -255,9 +256,10 @@ static String getSanitizedUserAgent() {
 
   static final class StringHeaderFactory implements LazyHeaderFactory {
 
+    @NonNull
     private final String value;
 
-    StringHeaderFactory(String value) {
+    StringHeaderFactory(@NonNull String value) {
       this.value = value;
     }