Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize the logging frequency for ProgressLogger. #8662

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

gbggrant
Copy link
Collaborator

Make the logging frequency used by the ProgressLogger available as an input. If not used, sets the default value.

Variants team is using a branch of gatk and have made this change there, so pulling this change into master to simplify future merges / branch updates.

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbggrant 👍

I'd really like to merge the asynchronous progress logger that logs every N seconds instead of N records to get around this problem.

@lbergelson
Copy link
Member

@gbggrant If you have more PR's into master it would be a good idea to tag someone on engine team. That way they won't get accidentally ignored. I tend to not look at the GVS PRs because I just assume they're being handled by the GVS team.

@lbergelson lbergelson merged commit bbc028b into master Feb 7, 2024
20 checks passed
@lbergelson lbergelson deleted the gg_parameterize_logging_in_gather_vcfs_cloud branch February 7, 2024 18:50
@gbggrant
Copy link
Collaborator Author

gbggrant commented Feb 7, 2024

Thanks @lbergelson !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants