Add Windows support #1592
Add Windows support #1592
Conversation
Windows uses the .ico format for application icons.
Modify the pyinstaller spec file to allow building a single .exe file on Windows.
Do not set Unix specific options when running on Windows. Use the CREATE_NO_WINDOW creation flag to avoid launching a visible console window.
On Windows, files with O_TEMPORARY flag cannot be opened more than once. python/cpython#88221 A better solution is needed.
RayyanAnsari
force-pushed
the
windows
branch
from
ff0866f to
15f214d
Compare
|
Good stuff! I'll try to test this on a VM, but the changes look sensible. Could we add Windows as testing OS on Github Actions? And maybe build a binary there too? |
|
Minor linting error about ordered imports. And one import will need a condition to check the OS. |
|
I'm not sure how to approach the fix for the temporary files, see my last commit 15f214d.
There are no Borg releases yet with Windows builds, so we would have to fetch a build off the CI. This PR is still a draft, because I haven't thoroughly tested it, and I know for a fact that remote repositories do not yet work in Borg.
Trivial fix, will do. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
real-yfprojects
added
type:enhancement
Fixes #1593