Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vorta for Windows #1207

Open
MatejKovacic opened this issue Feb 25, 2022 · 21 comments · May be fixed by #1592
Open

Vorta for Windows #1207

MatejKovacic opened this issue Feb 25, 2022 · 21 comments · May be fixed by #1592
Labels
os:windows Affects Windows only type:enhancement Improvement of an existing function

Comments

@MatejKovacic
Copy link

Sorry, this is not really a bug, but I would really like to see Vorta (and Borg) on Windows. I found Vorta for Linux really reliable and useful, but for Windows I have constant problems with backuping solutions. I am using free version of Veeam, but on one machine network link is failing quite often and when that happens, Veeam cannot finish the backup (to the SMB shared folder).

Using ssh and Borg in that case would be much useful and reliable, but unfortunately there are no really good instructions how to setup Vorta and Borg on Windows (10).

Anyone willing to start working on this (instructions and especially porting client to Windows directly)?

Anyway, many thanks for your work!

@real-yfprojects
Copy link
Collaborator

Before this is an option for vorta, borg must run on windows. There is an entry on installing borg in the wsl. But this is very experimental and FUSE isn't expected to work. As an alternative one could also try to install borg using pip but I doubt that all the dependencies are available on windows.

Vorta itself should work on windows for the main part.

@m3nu
Copy link
Contributor

m3nu commented Feb 25, 2022

Someone published Windows binaries for Borg for a while. So it's possible.

I'm not touching Windows with a 5ft pole, but would be up to packaging Vorta for Windows, once Borg runs.

Vorta is in pure Qt and Python, which already runs on Windows. For packaging we use Pyinstaller, which also supports Windows.

@m3nu
Copy link
Contributor

m3nu commented Feb 25, 2022

@bhlevca
Copy link

bhlevca commented Apr 6, 2022

I managed to compile borg on windows using visual studio compiler and modifying the __init__.py to include the dependent dlls.

Borg works fine for me on windows.

The big remaining problem is vorta. which seems to work on local folders but has problems with network shares and sockets.
for example:

Traceback (most recent call last):
  File "C:\MECP\WebGnome\WebGnomeEnv\lib\site-packages\vorta-0.8.3-py3.10.egg\vorta\views\repo_add_dialog.py", line 235, in run
    self.thread.run()
  File "C:\MECP\WebGnome\WebGnomeEnv\lib\site-packages\vorta-0.8.3-py3.10.egg\vorta\borg\borg_job.py", line 222, in run
    os.set_blocking(p.stdout.fileno(), False)
AttributeError: module 'os' has no attribute 'set_blocking

@real-yfprojects
Copy link
Collaborator

Vorta uses some functions of python's os module that are only available on unix.

@m3nu
Copy link
Contributor

m3nu commented Apr 7, 2022

Good news! There shouldn’t be many Unix-specific functions.

First prio would be to upstream the changes in Borg and start publishing official binaries.

@bhlevca
Copy link

bhlevca commented Apr 7, 2022

Vorta uses some functions of python's os module that are only available on unix.

That was the reason or opening this issue: To make it compatible with windows. Now that borg runs well on windows it makes even more sense

@bhlevca
Copy link

bhlevca commented Apr 7, 2022

Good news! There shouldn’t be many Unix-specific functions.

First prio would be to upstream the changes in Borg and start publishing official binaries.

Vorta does not need binaries as it is only based on python. Borg already works on windows, either get it form those who released it on windows or if you have the skill you can compile it yourself. I tried vorta on windows but it has some os calls that are not available on Windows and the code should be checking on the platform and use the call appropriate calls for that platform. Vorta is tested only on linux on intel platform. Support for aarch64 is also lacking.

@m3nu
Copy link
Contributor

m3nu commented Apr 8, 2022

We would include Borg binaries with Vorta so users don't need to compile them again.

Where can I find Windows binaries using the latest version? I just updated Borg's install scripts and from what I saw, some parts still need adjustments for Windows. I could be wrong of course, since I didn't try myself.

@stale
Copy link

stale bot commented Jun 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:stale This item will be closed soon due to inactivity label Jun 10, 2022
@real-yfprojects real-yfprojects added the type:enhancement Improvement of an existing function label Jun 11, 2022
@stale stale bot removed the status:stale This item will be closed soon due to inactivity label Jun 11, 2022
@alfredonodo

This comment was marked as off-topic.

@m3nu

This comment was marked as off-topic.

@alfredonodo

This comment was marked as off-topic.

@m3nu

This comment was marked as off-topic.

@alfredonodo

This comment was marked as off-topic.

@m3nu

This comment was marked as off-topic.

@real-yfprojects

This comment was marked as off-topic.

@alfredonodo

This comment was marked as off-topic.

@MatejKovacic
Copy link
Author

Sorry, guys, but here we are talking about Borgbackup/Vorta running on the Windows natively not through WSL or some kind of virtualisation.

I mean, what is the point of installing the whole Ubuntu to then run Borg and Vorta on the top of it...

@real-yfprojects

This comment was marked as off-topic.

@real-yfprojects real-yfprojects added the os:windows Affects Windows only label Feb 14, 2023
@ThomasWaldmann
Copy link
Collaborator

See PR #1592.

@real-yfprojects real-yfprojects linked a pull request Mar 4, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os:windows Affects Windows only type:enhancement Improvement of an existing function
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants