Remove miner from erigon command #124
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #124 +/- ##
============================================
- Coverage 41.71% 28.21% -13.50%
============================================
Files 74 168 +94
Lines 4898 7294 +2396
Branches 765 1311 +546
============================================
+ Hits 2043 2058 +15
- Misses 2749 5130 +2381
Partials 106 106
Flags with carried forward coverage won't be shown. Click here to find out more. |
| @@ -15,9 +14,6 @@ COMMON_FLAGS=" \ | |||
|
|
|||
| ERIGON_FLAGS=" \ | |||
| ${COMMON_FLAGS} \ | |||
| --mine \ | |||
There was a problem hiding this comment.
Removing the etherbase and the sigfile seems fine, but if --mine isn't enabled, then I don't believe erigon will build blocks and act as a sequencer.
I just tried removing it in op-e2e/extrernal_erigon/main.go and the tests simply hang for me. If we're removing it here, I'd think we should remove it there as well?
There was a problem hiding this comment.
I have removed it in our sequencer node. It's still building new blocks.
There was a problem hiding this comment.
Looks like this breaks the e2e in CI as well -- does it work on your system?
There was a problem hiding this comment.
No, I am trying to figure out why. The integration tests work, but op-e2e tests don't.
There was a problem hiding this comment.
Ok, figured out. The Regeneration ended observation should be removed. Geth also has this --mine option and it is not enabled in the op-e2e tests. I think we should be good to remove it.
https://github.com/ethereum-optimism/op-geth/blob/0402d543c3d0cff3a3d344c0f4f83809edb44f10/cmd/utils/flags.go#L457-L461
| @@ -160,10 +158,6 @@ func execute(binPath string, config external.Config) (*erigonSession, error) { | |||
| } | |||
| fmt.Fscanf(sess.Err, "%d", &enginePort) | |||
| fmt.Printf("================== op-erigon shim got engine port %d ==========================\n", enginePort) | |||
| gm.Eventually(sess.Err, time.Minute).Should(gbytes.Say("Regeneration ended")) | |||
There was a problem hiding this comment.
I think we should probably look for another message that indicates startup is done -- and we can hopefully eliminate the sleep below. But that's outside the scope of this PR, I'll take a look and submit separately.
Remove miner command