Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add expiration and limit size for policy #110

Merged
merged 8 commits into from
Mar 20, 2023
Merged

feat: add expiration and limit size for policy #110

merged 8 commits into from
Mar 20, 2023

Conversation

fynnss
Copy link
Contributor

@fynnss fynnss commented Mar 15, 2023 •
edited
Loading

Description

add expiration and limit size for statement in policy

Rationale

Permission expiration and scope are useful in many scenarios.

Example

  1. User A only allows user B to upload object data of the specified size within a specified time
  2. User A only wants user B to download object data within a specified time

Changes

Notable changes:

  • add expiration and limit size in statements
  • add more check
  • add policy unit test and e2e test

unclezoro
unclezoro requested changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@unclezoro unclezoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature seems not complete.

@fynnss
Copy link
Contributor Author

fynnss commented Mar 16, 2023

This feature seems not complete.

Yes, still working on it. Will ready soon

@fynnss fynnss force-pushed the fynn/add_expiration_and_limit_size_for_policy branch 3 times, most recently from 6f0a07b to 57b98bb Compare March 16, 2023 07:07
@unclezoro unclezoro marked this pull request as draft March 16, 2023 08:18
@fynnss fynnss force-pushed the fynn/add_expiration_and_limit_size_for_policy branch from 57b98bb to 1f90630 Compare March 16, 2023 12:49
@fynnss
Copy link
Contributor Author

fynnss commented Mar 16, 2023 •
edited
Loading

This feature seems not complete.

Yes, still working on it. Will ready soon

@guagualvcha @RenRick The PR is ready. pls help to review

@fynnss fynnss marked this pull request as ready for review March 16, 2023 12:51
@fynnss fynnss requested a review from unclezoro March 16, 2023 12:52
@fynnss fynnss added the r4r label Mar 16, 2023
@fynnss fynnss requested review from RenRick and flywukong March 17, 2023 00:52
@fynnss fynnss force-pushed the fynn/add_expiration_and_limit_size_for_policy branch from 3565f60 to 97dd763 Compare March 17, 2023 04:00
@fynnss fynnss requested a review from yutianwu March 17, 2023 04:52
@fynnss fynnss force-pushed the fynn/add_expiration_and_limit_size_for_policy branch from 6bb40c6 to 6753ee2 Compare March 17, 2023 07:00
RenRick
RenRick reviewed Mar 17, 2023
View reviewed changes
proto/greenfield/permission/types.proto Outdated Show resolved Hide resolved
proto/greenfield/permission/types.proto Outdated Show resolved Hide resolved
x/permission/keeper/keeper.go Outdated Show resolved Hide resolved
x/permission/keeper/keeper.go Outdated Show resolved Hide resolved
@fynnss fynnss force-pushed the fynn/add_expiration_and_limit_size_for_policy branch from 456ca71 to 72a42f0 Compare March 17, 2023 07:35
@fynnss fynnss requested review from RenRick and yutianwu March 17, 2023 07:36
@fynnss fynnss force-pushed the fynn/add_expiration_and_limit_size_for_policy branch from 5693240 to fea0b94 Compare March 20, 2023 01:34
@fynnss fynnss requested review from RenRick and flywukong March 20, 2023 01:42
@fynnss fynnss mentioned this pull request Mar 20, 2023
Merged
@fynnss fynnss requested a review from flywukong March 20, 2023 05:47
@fynnss fynnss merged commit f37c60f into develop Mar 20, 2023
This was referenced Mar 24, 2023
Merged
Merged
@unclezoro unclezoro deleted the fynn/add_expiration_and_limit_size_for_policy branch April 18, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RenRick RenRick RenRick approved these changes

@unclezoro unclezoro unclezoro approved these changes

@yutianwu yutianwu Awaiting requested review from yutianwu

@flywukong flywukong Awaiting requested review from flywukong

Assignees
No one assigned
Labels
r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fynnss @yutianwu @unclezoro @flywukong @RenRick