fix review comments

proto/greenfield/permission/types.proto

@@ -30,14 +30,17 @@ message Policy {
   repeated permission.Statement statements = 5;
   // expiration_time defines the whole expiration time of all the statements.
   // Notices: Its priority is higher than the expiration time inside the Statement
-  google.protobuf.Timestamp expiration_time = 7 [
+  google.protobuf.Timestamp expiration_time = 6 [
     (gogoproto.stdtime) = true,
     (gogoproto.nullable) = true
   ];
   // member_statement define a special policy which indicates that the principal is a member of the group
-  permission.Statement member_statement = 6;
+  permission.Statement member_statement = 7;
 }
 
+// PolicyGroup refers to a group of policies which grant permission to Group, which is limited to MaxGroupNum (default 10).
+// This means that a single resource can only grant permission to 10 groups. The reason for
+// this is to enable on-chain determination of whether an operator has permission within a limited time.
 message PolicyGroup {
   message Item {
     string policy_id = 1 [

x/permission/keeper/keeper.go

@@ -121,9 +121,9 @@ func (k Keeper) PutPolicy(ctx sdk.Context, policy *types.Policy) (math.Uint, err
 		if bz != nil {
 			policyGroup := types.PolicyGroup{}
 			k.cdc.MustUnmarshal(bz, &policyGroup)
-			if (uint64)(len(policyGroup.Items)) >= k.MaximumGroupNum(ctx) {
+			if (uint64)(len(policyGroup.Items)) >= k.MaximumPolicyGroupSize(ctx) {
 				return math.ZeroUint(), types.ErrLimitExceeded.Wrapf("group number limit to %d, actual %d",
-					k.MaximumGroupNum(ctx),
+					k.MaximumPolicyGroupSize(ctx),
 					len(policyGroup.Items))
 			}
 			isFound := false

x/permission/keeper/params.go

@@ -10,7 +10,7 @@ import (
 func (k Keeper) GetParams(ctx sdk.Context) types.Params {
 	return types.NewParams(
 		k.MaximumStatementsNum(ctx),
-		k.MaximumGroupNum(ctx))
+		k.MaximumPolicyGroupSize(ctx))
 }
 
 // SetParams set the params
@@ -23,7 +23,7 @@ func (k Keeper) MaximumStatementsNum(ctx sdk.Context) (res uint64) {
 	return
 }
 
-func (k Keeper) MaximumGroupNum(ctx sdk.Context) (res uint64) {
-	k.paramstore.Get(ctx, types.KeyMaxPolicyGroupNum, &res)
+func (k Keeper) MaximumPolicyGroupSize(ctx sdk.Context) (res uint64) {
+	k.paramstore.Get(ctx, types.KeyMaxPolicyGroupSIze, &res)
 	return
 }

x/permission/types/params.go

@@ -13,8 +13,8 @@ const (
 )
 
 var (
-	KeyMaxStatementsNum  = []byte("MaxStatementsNum")
-	KeyMaxPolicyGroupNum = []byte("MaxPolicyGroupNum")
+	KeyMaxStatementsNum   = []byte("MaxStatementsNum")
+	KeyMaxPolicyGroupSIze = []byte("MaxPolicyGroupSize")
 )
 
 var _ paramtypes.ParamSet = (*Params)(nil)
@@ -41,7 +41,7 @@ func DefaultParams() Params {
 func (p *Params) ParamSetPairs() paramtypes.ParamSetPairs {
 	return paramtypes.ParamSetPairs{
 		paramtypes.NewParamSetPair(KeyMaxStatementsNum, &p.MaximumStatementsNum, validateMaximumStatementsNum),
-		paramtypes.NewParamSetPair(KeyMaxPolicyGroupNum, &p.MaximumGroupNum, validateMaximumGroupNum),
+		paramtypes.NewParamSetPair(KeyMaxPolicyGroupSIze, &p.MaximumGroupNum, validateMaximumGroupNum),
 	}
 }