Feat/fe/refactor/input #1174
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| import { Stack, Typography, InputAdornment, IconButton } from "@mui/material"; | ||
| import { useTheme } from "@mui/material/styles"; | ||
| import { useState } from "react"; | ||
| import PropTypes from "prop-types"; | ||
| import VisibilityOff from "@mui/icons-material/VisibilityOff"; | ||
| import Visibility from "@mui/icons-material/Visibility"; | ||
| export const HttpAdornment = ({ https }) => { | ||
| const theme = useTheme(); | ||
| return ( | ||
| <Stack | ||
| direction="row" | ||
| alignItems="center" | ||
| height="100%" | ||
| sx={{ | ||
| borderRight: `solid 1px ${theme.palette.border.dark}`, | ||
| backgroundColor: theme.palette.background.accent, | ||
| pl: theme.spacing(6), | ||
| }} | ||
| > | ||
| <Typography | ||
| component="h5" | ||
| paddingRight={"var(--env-var-spacing-1-minus)"} | ||
| color={theme.palette.text.secondary} | ||
| sx={{ lineHeight: 1, opacity: 0.8 }} | ||
| > | ||
| {https ? "https" : "http"}:// | ||
| </Typography> | ||
| </Stack> | ||
| ); | ||
| }; | ||
|
|
||
| export const PasswordEndAdornment = ({ fieldType, setFieldType }) => { | ||
| const theme = useTheme(); | ||
| return ( | ||
| <InputAdornment position="end"> | ||
| <IconButton | ||
| aria-label="toggle password visibility" | ||
| onClick={() => setFieldType(fieldType === "password" ? "text" : "password")} | ||
| sx={{ | ||
| color: theme.palette.border.dark, | ||
| padding: theme.spacing(1), | ||
| "&:focus-visible": { | ||
| outline: `2px solid ${theme.palette.primary.main}`, | ||
| outlineOffset: `2px`, | ||
| }, | ||
| "& .MuiTouchRipple-root": { | ||
| pointerEvents: "none", | ||
| display: "none", | ||
| }, | ||
| }} | ||
| > | ||
| {fieldType === "password" ? <VisibilityOff /> : <Visibility />} | ||
| </IconButton> | ||
| </InputAdornment> | ||
| ); | ||
| }; | ||
|
Comment on lines
+32
to
+56
There was a problem hiding this comment. 🛠️ Refactor suggestion Lose yourself in the PropTypes, the moment, you better never let it go! The component is missing PropTypes validation for Add PropTypes: PasswordEndAdornment.propTypes = {
fieldType: PropTypes.oneOf(['password', 'text']).isRequired,
setFieldType: PropTypes.func.isRequired,
};Optimize with memo: +import { memo } from 'react';
-export const PasswordEndAdornment = ({ fieldType, setFieldType }) => {
+export const PasswordEndAdornment = memo(({ fieldType, setFieldType }) => {
// ... component code ...
-};
+}); |
||
|
|
||
| HttpAdornment.propTypes = { | ||
| https: PropTypes.bool.isRequired, | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yo dawg, you've got an unused import there!
The
useStateimport isn't being used in either component. Let's keep our code clean like mom's spaghetti!-import { useState } from "react";📝 Committable suggestion