Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log webrtc stats and events #1179

Conversation

rafaellehmkuhl
Copy link
Member

Example of data extracted from this:

image

To be merged after #1173.
Fix #1135.

Library used to collect WebRTC streams stats.
This include logs of averages for dynamic values as well as warns on increases for cumulative values.
@rafaellehmkuhl rafaellehmkuhl force-pushed the log-webrtc-stats-and-events branch from cb25e03 to 5b0608b Compare August 2, 2024 14:13
@ArturoManzoli
Copy link
Contributor

ArturoManzoli commented Aug 2, 2024

I can't see the messages from you example above.
Do I need to enable something?
Even with the console in verbose mode I couldn't find those.

Screenshare.-.2024-08-02.11_13_31.AM.mp4

@ArturoManzoli
Copy link
Contributor

ArturoManzoli commented Aug 2, 2024

How about creating an overlay for the main view with those infos?
User would enable it on dev mode and it could look like this, but with our visual identity and some transparency:

image

@rafaellehmkuhl
Copy link
Member Author

I can't see the messages from you example above. Do I need to enable something? Even with the console in verbose mode I couldn't find those.

The warning will only happen if you're having problems in the connection.

The debug logs should be there in Verbose mode. It should be hidden between the regular video debug logs. Can you try looking for "average" there?

@joaoantoniocardoso
Copy link
Member

How about creating an overlay for the main view with those infos? User would enable it on dev mode and it could look like this, but with our visual identity and some transparency:

image

at least for debugging, that'd be great

@ArturoManzoli
Copy link
Contributor

The debug logs should be there in Verbose mode. It should be hidden between the regular video debug logs. Can you try looking for "average" there?

Yep! It's there
image

Copy link
Contributor

@ArturoManzoli ArturoManzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @rafaellehmkuhl. We can also wait for @joaoantoniocardoso approval before merging
I think the major goal is achieved for now with the logs on terminal.
But we should consider in the near future to add a debug overlay on the main view, so it can be used on mobiles devices also.

@rafaellehmkuhl
Copy link
Member Author

@joaoantoniocardoso @ArturoManzoli I totally agree!
This PR is just a start. We want to start collecting performance indicators to better know whats going on with different setups, but we can definitely expand from there.

Copy link
Member

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, let's do it, then

@joaoantoniocardoso joaoantoniocardoso merged commit d5badce into bluerobotics:master Aug 2, 2024
8 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the log-webrtc-stats-and-events branch August 2, 2024 16:49
@rafaellehmkuhl
Copy link
Member Author

Opened #1185 to track that.

@rafaellehmkuhl
Copy link
Member Author

Fix #1031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add statistics about video streams
3 participants