-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log webrtc stats and events #1179
Log webrtc stats and events #1179
Conversation
Library used to collect WebRTC streams stats.
This include logs of averages for dynamic values as well as warns on increases for cumulative values.
cb25e03
to
5b0608b
Compare
I can't see the messages from you example above. Screenshare.-.2024-08-02.11_13_31.AM.mp4 |
The warning will only happen if you're having problems in the connection. The debug logs should be there in Verbose mode. It should be hidden between the regular video debug logs. Can you try looking for "average" there? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @rafaellehmkuhl. We can also wait for @joaoantoniocardoso approval before merging
I think the major goal is achieved for now with the logs on terminal.
But we should consider in the near future to add a debug overlay on the main view, so it can be used on mobiles devices also.
@joaoantoniocardoso @ArturoManzoli I totally agree! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, let's do it, then
Opened #1185 to track that. |
Fix #1031 |
Example of data extracted from this:
To be merged after #1173.
Fix #1135.