Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add framerate logging for both application rendering and video streams #1173

Merged

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Jul 31, 2024

image

The average framerate is logged at debug level every second, while the framerate drop logs happen if a 10% threshold is archieved.

I've evaluated the application for any performance loss but couldn't notice any.

Fix #1162
Fix #1163

@ArturoManzoli
Copy link
Contributor

In my case, there is always a warning saying that a low framerate was detected, even though the frame rate is high, about 120 fps.

I got a little confused with what is a normal framerate (for me 60 fps is ok).

image

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Aug 1, 2024

In my case, there is always a warning saying that a low framerate was detected, even though the frame rate is high, about 120 fps.

I got a little confused with what is a normal framerate (for me 60 fps is ok).

By "low framerate" there I mean that there was a drop in the framerate.
Your's is probably around 124Hz by default (your monitor is probably a high-frequency one, right?).

Will adjust the text to "A drop in the framerate was detected [...]"

@rafaellehmkuhl rafaellehmkuhl force-pushed the add-performance-stats branch from f119c55 to cbaf3cc Compare August 1, 2024 17:10
@ArturoManzoli
Copy link
Contributor

(your monitor is probably a high-frequency one, right?).

Will adjust the text to "A drop in the framerate was detected [...]"

Yep, 144Hz.

@rafaellehmkuhl
Copy link
Member Author

(your monitor is probably a high-frequency one, right?).

Will adjust the text to "A drop in the framerate was detected [...]"

Yep, 144Hz.

Change done!

@rafaellehmkuhl rafaellehmkuhl requested review from ArturoManzoli and removed request for ArturoManzoli August 1, 2024 22:24
@ArturoManzoli ArturoManzoli merged commit 6abdcb9 into bluerobotics:master Aug 2, 2024
8 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the add-performance-stats branch August 2, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log VideoPlayer widget framerate Log Cockpit's animation framerate
2 participants