Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editline not being built/linked #1948

Closed
3 tasks
pmconrad opened this issue Aug 21, 2019 · 4 comments · Fixed by bitshares/bitshares-fc#151 or bitshares/bitshares-fc#157
Closed
3 tasks

Editline not being built/linked #1948

pmconrad opened this issue Aug 21, 2019 · 4 comments · Fixed by bitshares/bitshares-fc#151 or bitshares/bitshares-fc#157
Assignees
@pmconrad
Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 4d Critical Priority Priority indicating system stoppage may occur and no workaround exists 6 Build Impact flag identifying the build process 6 CLI Impact flag identifying the command line interface (CLI) wallet application
Milestone
3.3.0 - Feature R...

Comments

@pmconrad
Copy link
Contributor

Build Error Description
The latest testnet branch does not build nor link the editline library. As a result, some cli_wallet functionality is missing, in particular the new secure password entry method.

Build Environment
Details about the build environment, including the relevant required libraries. Much of this information can be found in the CMakeFiles/CMakeOutput.log.

  • Host OS: Linux
  • Source Branch/Tag: latest testnet
  • Boost Version: 1.66.0
  • C++ Compiler: gcc-7.4.1
  • CMake: 3.10.2

CORE TEAM TASK LIST

  • Evaluate Build Error
  • Provide build guidance
  • Create Bug Report
@pmconrad pmconrad added 3d Bug Classification indicating the existing implementation does not match the intention of the design 4d Critical Priority Priority indicating system stoppage may occur and no workaround exists 6 Build Impact flag identifying the build process 6 CLI Impact flag identifying the command line interface (CLI) wallet application labels Aug 21, 2019
@pmconrad pmconrad added this to the 3.3.0 - Feature Release milestone Aug 21, 2019
@pmconrad pmconrad self-assigned this Aug 21, 2019
@pmconrad pmconrad mentioned this issue Aug 21, 2019
Merged
@pmconrad
Copy link
Contributor Author

Fixed by bitshares/bitshares-fc#151 - need to bump fc in release branch to ea85954 .

pmconrad added a commit to pmconrad/bitshares-core that referenced this issue Aug 21, 2019
@pmconrad
Bump fc to fix bitshares#1948
34372a7
@pmconrad pmconrad mentioned this issue Aug 21, 2019
Merged
@MichelSantos MichelSantos mentioned this issue Aug 21, 2019
Closed
@abitmore
Copy link
Member

Will close after bumped FC in #1949.

@abitmore abitmore reopened this Aug 21, 2019
@pmconrad pmconrad mentioned this issue Aug 30, 2019
Merged
@abitmore
Copy link
Member

Will close after bumped FC in #1949.

@abitmore abitmore reopened this Aug 30, 2019
@pmconrad
Copy link
Contributor Author

pmconrad commented Sep 1, 2019

Merged #1949.

@pmconrad pmconrad closed this as completed Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmconrad pmconrad

Labels
3d Bug Classification indicating the existing implementation does not match the intention of the design 4d Critical Priority Priority indicating system stoppage may occur and no workaround exists 6 Build Impact flag identifying the build process 6 CLI Impact flag identifying the command line interface (CLI) wallet application
Projects
None yet
Milestone
3.3.0 - Feature Release
2 participants
@pmconrad @abitmore