Clear cache users between tests

lib/teiserver/libs/test_lib.ex

@@ -121,7 +121,7 @@
     # This is because upon disconnecting, the server does a bunch of DB call for logging
     # and telemetry. The disconnection happen when the tcp socket is closed, and by
     # that time, the test has ended and the SQL sandbox closed.
     ExUnit.Callbacks.on_exit(fn -> Teiserver.Client.disconnect(user.id) end)
     %{socket: socket, user: user, pid: pid}
   end
 
@@ -660,7 +660,12 @@
       :telemetry_simple_client_event_types_cache,
       :telemetry_simple_lobby_event_types_cache,
       :telemetry_simple_match_event_types_cache,
-      :telemetry_simple_server_event_types_cache
+      :telemetry_simple_server_event_types_cache,
+      :users,
+      :users_lookup_id_with_discord,
+      :users_lookup_id_with_email,
+      :users_lookup_id_with_name,
+      :users_lookup_name_with_id
     ]
 
     Enum.each(cache_list, fn cache ->

test/support/data_case.ex

@@ -1,4 +1,4 @@
 defmodule Teiserver.DataCase do
   @moduledoc """
   This module defines the setup for tests requiring
   access to the application's data layer.
@@ -16,7 +16,7 @@
 
   use ExUnit.CaseTemplate
 
   using do
     quote do
       alias Teiserver.Repo
 
@@ -32,11 +32,12 @@
   """
   def setup_sandbox(tags) do
     pid = Ecto.Adapters.SQL.Sandbox.start_owner!(Teiserver.Repo, shared: not tags[:async])
     on_exit(fn -> Ecto.Adapters.SQL.Sandbox.stop_owner(pid) end)
   end
 
   setup tags do
     setup_sandbox(tags)
+    on_exit(&Teiserver.TeiserverTestLib.clear_all_con_caches/0)
     :ok
   end
 

test/teiserver/caches_test.exs

@@ -0,0 +1,25 @@
+defmodule Teiserver.CachesTest do
+  use Teiserver.DataCase, async: false
+
+  # This module is merely here to check that
+  # Teiserver.TeiserverTestLib.clear_all_con_caches does indeed clear the advertised
+  # cache across tests.
+  # because all queries rely heavily on caches, it's important to clear them between
+  # tests so as not to pollute other tests
+
+  test "Clear user caches 1" do
+    name = "ClearDbEachTestUser"
+    assert is_nil(Teiserver.CacheUser.get_user_by_name(name))
+    user = Teiserver.TeiserverTestLib.new_user(name)
+    result = Teiserver.CacheUser.get_user_by_id(user.id)
+    assert result[:name] == name
+  end
+
+  test "Clear user caches 2" do
+    name = "ClearDbEachTestUser"
+    assert is_nil(Teiserver.CacheUser.get_user_by_name(name))
+    user = Teiserver.TeiserverTestLib.new_user(name)
+    result = Teiserver.CacheUser.get_user_by_id(user.id)
+    assert result[:name] == name
+  end
+end