Clear cache users between tests #342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This must be done for data cases as well as server cases. Because most of the querying logic rely under the hood on the caches, when someone creates a user, it won't be persisted to the DB after the test, but the cache will not be rolled back.
|
I tested and it worked with this test: Would be better if some sort of test was included in this PR. |
|
I've added a test in f543bcc. Not sure of its value but it's something at least. |
|
Yeah I was thinking of the add user test that caused me to find the bug in the first place. |
geekingfrog
force-pushed
the
geekingfrog/clear-user-cache-between-tests
branch
from
f543bcc to
dedf5a4
Compare
|
Alright, I amended the commit and ended up using your test file. Not the biggest fan, but it's a start and definitely better than nothing. |
jauggy
approved these changes
Jul 1, 2024
|
I'm going to hold off merging that, there's something fishy going on with some tests :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This must be done for data cases as well as server cases. Because most of the querying logic rely under the hood on the caches, when someone creates a user, it won't be persisted to the DB after the test, but the cache will not be rolled back.