Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic mouse capture API #679

Merged
merged 14 commits into from
Oct 16, 2020
Merged

Added basic mouse capture API #679

merged 14 commits into from
Oct 16, 2020

Conversation

alexb910
Copy link
Contributor

@alexb910 alexb910 commented Oct 14, 2020

Addresses #642.

@alexb910 alexb910 marked this pull request as draft October 14, 2020 12:41
@karroffel karroffel added C-Feature A new feature, making something new possible C-Examples An addition or correction to our examples A-Input Player input via keyboard, mouse, gamepad, and more A-Windowing Platform-agnostic interface layer to run your app in labels Oct 14, 2020
@alexb910 alexb910 marked this pull request as ready for review October 14, 2020 13:10
@cart
Copy link
Member

cart commented Oct 15, 2020

This definitely works, but for consistency I think we should port this to using the getters/setters introduced in this pr: #644 (which we just merged)

@cart
Copy link
Member

cart commented Oct 16, 2020

Looks like you accidentally added new versions some past commits. I fixed this by rebasing on master. Not really a huge deal either way because we squash+merge every pr, but the rebase made it slightly easier to review / removed a bunch of unnecessary participants.

@@ -296,3 +313,36 @@ fn handle_create_window_events(
window_created_events.send(WindowCreated { id: window_id });
}
}

fn handle_cursor_state_change_events(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need these events anymore. I'd prefer the Window getters/setters to be the one way to set these things

@cart cart merged commit d004bce into bevyengine:master Oct 16, 2020
@cart cart mentioned this pull request Oct 16, 2020
@naithar naithar mentioned this pull request Oct 17, 2020
joshuajbouw pushed a commit to joshuajbouw/bevy that referenced this pull request Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Input Player input via keyboard, mouse, gamepad, and more A-Windowing Platform-agnostic interface layer to run your app in C-Examples An addition or correction to our examples C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants