[Merged by Bors] - Use u32 over usize for ComponentSparseSet indicies #4723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
A-ECS
alice-i-cecile
approved these changes
May 14, 2022
|
As @TheRawMeatball stated, the cast is likely inconsequential. Here are the relevant benchmark results, most of these are within a reasonable margin of error, but there are notable speedups in sparse set iteration with the indexes being smaller, and thus a bit more cache friendly. |
|
@bevyengine/ecs-team more performance optimizations that are ready to review. |
|
To add to this, a lot of the stored usizes we have could also be u32s. Most notably Archetype::entity_table_rows, which could speed up archetype based iteration in general. I'll leave this for a separate PR so we can benchmark each part in isolation. |
bjorn3
reviewed
May 18, 2022
bjorn3
reviewed
May 18, 2022
BoxyUwU
approved these changes
May 18, 2022
BoxyUwU
reviewed
May 18, 2022
james7132
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 30, 2022
# Objective Use less memory to store SparseSet components. ## Solution Change `ComponentSparseSet` to only use `Entity::id` in it's key internally, and change the usize value in it's SparseArray to use u32 instead, as it cannot have more than u32::MAX live entities stored at once. This should reduce the overhead of storing components in sparse set storage by 50%.
bors
bot
changed the title
|
This appears to have caused a failure on release builds. EDIT: @james7132 said they'll tackle this, the problem is with the debug asserts getting compiled in release mode, where the types differ.
|
james7132
added a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
# Objective Use less memory to store SparseSet components. ## Solution Change `ComponentSparseSet` to only use `Entity::id` in it's key internally, and change the usize value in it's SparseArray to use u32 instead, as it cannot have more than u32::MAX live entities stored at once. This should reduce the overhead of storing components in sparse set storage by 50%.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective Use less memory to store SparseSet components. ## Solution Change `ComponentSparseSet` to only use `Entity::id` in it's key internally, and change the usize value in it's SparseArray to use u32 instead, as it cannot have more than u32::MAX live entities stored at once. This should reduce the overhead of storing components in sparse set storage by 50%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Use less memory to store SparseSet components.
Solution
Change
ComponentSparseSetto only useEntity::idin it's key internally, and change the usize value in it's SparseArray to use u32 instead, as it cannot have more than u32::MAX live entities stored at once.This should reduce the overhead of storing components in sparse set storage by 50%.