Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hot asset reloading on Windows #394

Merged
merged 1 commit into from
Aug 30, 2020

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Aug 30, 2020

Fixes #348

The change to use fully qualified names is to work around rust-lang/rust-analyzer#1165. This let me jump into the notify source and find https://github.com/notify-rs/notify/blob/05da071c09b2e50b68630430ff02023410f9e40a/src/windows.rs#L377-L381, showing that in Windows environments, only ModifyKind::Any is used.

Fixes bevyengine#348

Changes to uses fully qualified names to work around
rust-lang/rust-analyzer#1165
@karroffel karroffel added A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior O-Windows Specific to the Windows desktop operating system labels Aug 30, 2020
@cart
Copy link
Member

cart commented Aug 30, 2020

Looks good to me. Thanks!

@cart cart merged commit 61b5fe9 into bevyengine:master Aug 30, 2020
@DJMcNab DJMcNab deleted the windows-reloading branch August 30, 2020 19:00
mrk-its pushed a commit to mrk-its/bevy that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior O-Windows Specific to the Windows desktop operating system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scene reloading does not work on windows.
3 participants