Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scene reloading does not work on windows. #348

Closed
shelbyd opened this issue Aug 26, 2020 · 2 comments · Fixed by #394
Closed

Scene reloading does not work on windows. #348

shelbyd opened this issue Aug 26, 2020 · 2 comments · Fixed by #394
Labels
C-Bug An unexpected or incorrect behavior

Comments

@shelbyd
Copy link

shelbyd commented Aug 26, 2020 •
edited
Loading

This can be reproduced with the "scene" example.

Reproduction

Clone bevy repo.
Run cargo run --example scene.
Change property x of entity 328997855 from 3.0 to 5.0.
Save the file.

Expected

Console message indicating the value was changed.

Actual

No console message.

Extra Info

Commit tested: 9aff0bc
Windows version: 10.0.18362 Build 18362
@Xavientois
Copy link
Contributor

Same behaviour is occurring for me on mac.

Extra Info

macOS 10.14.2

@GabCampbell GabCampbell added C-Bug An unexpected or incorrect behavior focus-area and removed focus-area labels Aug 26, 2020
@DJMcNab
Copy link
Member

DJMcNab commented Aug 27, 2020

This can be fixed by changing

bevy/crates/bevy_asset/src/asset_server.rs

Line 201 in 63fd4ae

kind: EventKind::Modify(ModifyKind::Data(_)),

to

 kind: EventKind::Modify(_),

but I haven't tested for unintended consequences yet.

DJMcNab added a commit to DJMcNab/bevy that referenced this issue Aug 30, 2020
@DJMcNab
Fix hot asset reloading on Windows
e61dc95 
Fixes bevyengine#348

Changes to uses fully qualified names to work around
rust-lang/rust-analyzer#1165
@DJMcNab DJMcNab mentioned this issue Aug 30, 2020
Merged
@cart cart closed this as completed in #394 Aug 30, 2020
cart pushed a commit that referenced this issue Aug 30, 2020
@DJMcNab
Fix hot asset reloading on Windows (#394)
61b5fe9 
Fixes #348

Changes to uses fully qualified names to work around
rust-lang/rust-analyzer#1165
mrk-its pushed a commit to mrk-its/bevy that referenced this issue Oct 6, 2020
@DJMcNab @mrk-its
Fix hot asset reloading on Windows (bevyengine#394)
b04b0ac 
Fixes bevyengine#348

Changes to uses fully qualified names to work around
rust-lang/rust-analyzer#1165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hot asset reloading on Windows DJMcNab/bevy
4 participants
@shelbyd @GabCampbell @Xavientois @DJMcNab