Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update dependencies ron winit& fix cargo-deny lists #3244

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - Update dependencies ron winit& fix cargo-deny lists #3244

wants to merge 9 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Dec 3, 2021

Objective

  • there are a few new versions for ron, winit, ndk, raw-window-handle
  • cargo-deny is failing due to new security issues / duplicated dependencies

Solution

  • Update our dependencies
  • Note all new security issues, with which of Bevy direct dependency it comes from
  • Update duplicate crate list, with which of Bevy direct dependency it comes from

notify is not updated here as it's in #2993

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 3, 2021
@mockersf mockersf added C-Dependencies A change to the crates that Bevy depends on and removed S-Needs-Triage This issue needs to be labelled labels Dec 3, 2021
@alice-i-cecile
Copy link
Member

error: failed to run custom build command for wayland-sys v0.29.1

Caused by:
process didn't exit successfully: /home/runner/work/bevy/bevy/target/debug/build/wayland-sys-465716ae7e3b3f27/build-script-build (exit status: 101)
--- stdout
cargo:rerun-if-env-changed=WAYLAND_CLIENT_NO_PKG_CONFIG
cargo:rerun-if-env-changed=PKG_CONFIG_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG
cargo:rerun-if-env-changed=PKG_CONFIG
cargo:rerun-if-env-changed=WAYLAND_CLIENT_STATIC
cargo:rerun-if-env-changed=WAYLAND_CLIENT_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_PATH
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR

--- stderr
thread 'main' panicked at 'called Result::unwrap() on an Err value: "pkg-config" "--libs" "--cflags" "wayland-client" did not exit successfully: exit status: 1

What's up with this CI error? Seems to be responsible for both failing steps?

alice-i-cecile
alice-i-cecile reviewed Dec 4, 2021
View reviewed changes
deny.toml
{ name = "darling_macro", version = "0.10" }, # from rodio v0.14.0
{ name = "mach", version = "0.2" }, # from gilrs v0.8.1
{ name = "mio", version = "0.7" }, # from notify v5.0.0-pre.11
{ name = "ndk", version = "0.3" }, # from rodio v0.14.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does rodio itself pull in two versions of ndk?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rodio is using oboe which depends on ndk 0.4 and cpal which depends on ndk 0.3. I only noted the dependency from Bevy, not the complete dependency path

@mockersf
Copy link
Member Author

mockersf commented Dec 4, 2021

What's up with this CI error? Seems to be responsible for both failing steps?

Building with all features on linux needs two extra dependencies: libwayland-dev and libxkbcommon-dev. I'm guessing the first is needed for wayland, not sure exactly about the second one. It would be nice if someone on linux could check and document on Bevy dependencies for linux

@mockersf
Copy link
Member Author

mockersf commented Dec 4, 2021

ci failure is from a random network error, everything should be green now 👍

@parasyte
Copy link
Contributor

parasyte commented Dec 4, 2021

Heads up! winit 0.26.0 breaks transparent windows on Windows 11, which will negatively affect #3105

Upstream issue: rust-windowing/winit#2082

@mockersf
Copy link
Member Author

mockersf commented Dec 9, 2021

Would it fix transparency on linux (rust-windowing/winit#2006)?

@parasyte
Copy link
Contributor

parasyte commented Dec 9, 2021

It is mentioned in the changelog, so I think the update would fix transparent windows on X11.

@heavyrain266
Copy link

Building with all features on linux needs two extra dependencies: libwayland-dev and libxkbcommon-dev. I'm guessing the first is needed for wayland, not sure exactly about the second one. It would be nice if someone on linux could check and document on Bevy dependencies for linux

Package libxkbcommon is shared libinput wrapper used by X11 and Wayland as general input library which is definitely required to work with bevy.

@mockersf
Copy link
Member Author

mockersf commented Dec 9, 2021

bors try

bors bot added a commit that referenced this pull request Dec 9, 2021
@bors
Try #3244:
a2ba507
@bors
Copy link
Contributor

bors bot commented Dec 9, 2021

try

Build succeeded:

@mockersf mockersf force-pushed the update-dependencies-2112 branch from 8d3782e to fc1acaf Compare December 9, 2021 12:04
@bjorn3 bjorn3 mentioned this pull request Dec 9, 2021
Closed
@cart
Copy link
Member

cart commented Dec 9, 2021

Nice work!

@cart
Copy link
Member

cart commented Dec 9, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 9, 2021
@mockersf
Update dependencies ron winit& fix cargo-deny lists (#3244)
92a7e16 
# Objective

- there are a few new versions for `ron`, `winit`, `ndk`, `raw-window-handle`
- `cargo-deny` is failing due to new security issues / duplicated dependencies

## Solution

- Update our dependencies
- Note all new security issues, with which of Bevy direct dependency it comes from
- Update duplicate crate list, with which of Bevy direct dependency it comes from

`notify` is not updated here as it's in #2993
@bors
Copy link
Contributor

bors bot commented Dec 9, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update dependencies ron winit& fix cargo-deny lists [Merged by Bors] - Update dependencies ron winit& fix cargo-deny lists Dec 9, 2021
@bors bors bot closed this Dec 9, 2021
@AngelOnFira AngelOnFira mentioned this pull request Aug 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile left review comments

Assignees
No one assigned
Labels
C-Dependencies A change to the crates that Bevy depends on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mockersf @alice-i-cecile @parasyte @heavyrain266 @cart