Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Added transparency to window builder #3105

Closed
wants to merge 16 commits into from
Closed

[Merged by Bors] - Added transparency to window builder #3105

wants to merge 16 commits into from

Conversation

louiidev
Copy link
Contributor

Applogies, had to recreate this pr because of branching issue.
Old PR: #3033

Objective

Fixes #3032

Allowing a user to create a transparent window

Solution

I've allowed the transparent bool to be passed to the winit window builder

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Nov 10, 2021
@alice-i-cecile alice-i-cecile added A-Windowing Platform-agnostic interface layer to run your app in C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Triage This issue needs to be labelled labels Nov 10, 2021
@MiniaczQ
Copy link
Contributor

Code looks fine,
sucks that it's not supported on so many platforms.

@louiidev
Copy link
Contributor Author

louiidev commented Nov 10, 2021 •
edited
Loading

Code looks fine, sucks that it's not supported on so many platforms.

Well it only makes sense for Desktop platforms (Windows, Mac, Linux) and:

I think I found a workaround on Linux, forcing winit to run on it's master branch fixes this, or at least just on my Manjaro Linux machine with Nvidia proprietary drivers. I'm assuming that this now works because of this PR: rust-windowing/winit#2006

Originally posted by @Supermath101 in #3032 (comment)

So if that gets updated in the future then only mac will not be supported which might get fixed by this issue: gfx-rs/wgpu#687

I'm assuming the mac issue is caused by wgpu since the window transparency works with winit by itself.

@louiidev
Copy link
Contributor Author

bors try

@bors
Copy link
Contributor

bors bot commented Nov 15, 2021

🔒 Permission denied

Existing reviewers: click here to make louisgjohnson a reviewer

@alice-i-cecile
Copy link
Member

@louisgjohnson, you need to be on the Bevy org to be able to do that :) It's a low bar (pretty much just "good faith"), just ping cart on Discord or Github.

@alice-i-cecile
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Nov 15, 2021
@bors
Try #3105:
685262d
@bors
Copy link
Contributor

bors bot commented Nov 15, 2021

try

Build succeeded:

@mockersf
Copy link
Member

mockersf commented Nov 15, 2021 •
edited
Loading

I think I found a workaround on Linux, forcing winit to run on it's master branch fixes this, or at least just on my Manjaro Linux machine with Nvidia proprietary drivers. I'm assuming that this now works because of this PR: rust-windowing/winit#2006

Originally posted by @Supermath101 in #3032 (comment)

If it won't work by default on linux, then linux should be mentioned in the platform specific documentation

Adding the various related issues from winit and wgpu in comments could also help keep track of their status

@alice-i-cecile alice-i-cecile mentioned this pull request Nov 16, 2021
Closed
@louiidev louiidev requested a review from mockersf November 17, 2021 10:50
@louiidev louiidev requested a review from mockersf November 20, 2021 00:27
@parasyte parasyte mentioned this pull request Dec 4, 2021
Closed
@cart
Copy link
Member

cart commented Dec 8, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 8, 2021
@louiidev
Added transparency to window builder (#3105)
3ca8844 
Applogies, had to recreate this pr because of branching issue.
Old PR: #3033

# Objective

Fixes #3032

Allowing a user to create a transparent window 

## Solution

I've allowed the transparent bool to be passed to the winit window builder
@bors
Copy link
Contributor

bors bot commented Dec 8, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Added transparency to window builder [Merged by Bors] - Added transparency to window builder Dec 8, 2021
@bors bors bot closed this Dec 8, 2021
@rezural
Copy link
Contributor

rezural commented Dec 11, 2021

@louisgjohnson I can confirm this works on Ubuntu 20.04 with nvidia 1070, on bevy main.

@Supermath101 Supermath101 mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@IceSentry IceSentry IceSentry approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow window to be transparent
7 participants
@louiidev @MiniaczQ @alice-i-cecile @mockersf @cart @rezural @IceSentry