Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ordering information to observer tests (#14332) #15178

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Added ordering information to observer tests (#14332) #15178

merged 1 commit into from
Sep 14, 2024

Conversation

Wcubed
Copy link
Contributor

@Wcubed Wcubed commented Sep 12, 2024

Fixes #14332 by recording the order in which the events occur.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 13, 2024
@alice-i-cecile alice-i-cecile added X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Sep 13, 2024
@SpecificProtagonist
Copy link
Contributor

Hm, I don't know if this makes it more readable – though I very much like the rename from R to Order!
It's not clear to me what the original issue was intending, so I'll be interested in hearing Nth chime in.

@NthTensor
Copy link
Contributor

NthTensor commented Sep 13, 2024 •
edited
Loading

Issue relates to this review comment: #13991 (comment). May as well ping @iiYese.

@iiYese
Copy link
Contributor

iiYese commented Sep 13, 2024

@SpecificProtagonist The issue with counter based tests is they don't account for which observers fired or how many times they fired which means they won't catch certain bugs. These tests look like what I had in mind when I did that review.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 14, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 14, 2024
Merged via the queue into bevyengine:main with commit 70808af Sep 14, 2024
33 checks passed
@Wcubed Wcubed deleted the observer_tests_redone branch September 17, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iiYese iiYese iiYese approved these changes

@NthTensor NthTensor NthTensor approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Observers tests are not particularly robust
5 participants
@Wcubed @SpecificProtagonist @NthTensor @iiYese @alice-i-cecile