Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observers tests are not particularly robust #14332

Closed
alice-i-cecile opened this issue Jul 15, 2024 · 0 comments · Fixed by #15178
Closed

Observers tests are not particularly robust #14332

alice-i-cecile opened this issue Jul 15, 2024 · 0 comments · Fixed by #15178
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon

Comments

@alice-i-cecile
Copy link
Member

The observers tests should be updated to use a hash-map of counters probably.

Originally posted by @NthTensor in #13991 (comment)
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Jul 15, 2024
Wcubed added a commit to Wcubed/bevy that referenced this issue Sep 12, 2024
@Wcubed
Added ordering information to observer tests (bevyengine#14332)
dbc4e21
@Wcubed Wcubed mentioned this issue Sep 12, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Sep 14, 2024
@Wcubed
Added ordering information to observer tests (#14332) (#15178)
70808af 
Fixes #14332 by recording the order in which the events occur.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! X-Uncontroversial This work is generally agreed upon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added ordering information to observer tests (#14332) Wcubed/bevy
1 participant
@alice-i-cecile