feat: added support for inherited_environment in scala_test rule #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerlh
force-pushed
the
feat/inherited_environment
branch
from
858e7dd to
2f3cec9
Compare
omerlh
commented
Jun 1, 2022
fmeum
approved these changes
Jun 1, 2022
omerlh
force-pushed
the
feat/inherited_environment
branch
7 times, most recently
from
f6e741d to
8b06303
Compare
liucijus
reviewed
Jun 2, 2022
omerlh
force-pushed
the
feat/inherited_environment
branch
from
8b06303 to
c8b3982
Compare
omerlh
force-pushed
the
feat/inherited_environment
branch
from
c8b3982 to
ae09a02
Compare
liucijus
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for
inherited_environmentinscala_testruleFollow up on this slack thread I added support for the new
inherited_environmenttoscala_test.This feature requires Bazel version 5.2 rc0 or higher.
Motivation
While Bazel run tests in isolated environments, when running integration tests there is a need to pass env vars to the tested code - for example, credentials for external systems like databases. This PR added a new flag that is already supported by Bazel.
Note: I am a total noob. I got a lot of help on Slack in order to get to this point but I am not 100% understand everything I changed 🤦 I added a test so I know it is working, I will be helping to have some guidelines on how to run it only on Bazel 5.2:
test_rules_scalaand let it know it should run this test?Also - where and how should I document it?