Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support env_inherit for go_test #3241

Closed
JohnnyMorganz opened this issue Jul 19, 2022 · 0 comments · Fixed by #3256
Closed

Support env_inherit for go_test #3241

JohnnyMorganz opened this issue Jul 19, 2022 · 0 comments · Fixed by #3256

Comments

@JohnnyMorganz
Copy link

What version of rules_go are you using?

v0.33.0

What version of gazelle are you using?

v0.26.0

What version of Bazel are you using?

5.2.0

Does this issue reproduce with the latest releases of all the above?

Yes

What operating system and processor architecture are you using?

MacOS Monterry (12.4) Arm64

Any other potentially useful information about your toolchain?

What did you do?

I wanted to use env_inherit in go_test to pass through an environment variable

What did you expect to see?

The environment variable pass through successfully

What did you see instead?

env_inherit is not supported.


go_test currently allows defining fixed environment variables through env, but not passing through inherited environment variables. This was added to starlark support in Bazel 5.2 (https://blog.bazel.build/2022/06/08/bazel-5.2.html#starlark)

Example in rules_scala: bazelbuild/rules_scala#1401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant