Fix kt_compiler_plugin not working with android_binary #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongerrish
requested review from
cgruber,
djwhang,
jin,
restingbull and
timpeut
as code owners
restingbull
requested changes
Nov 12, 2020
| @@ -236,7 +236,7 @@ def kt_jvm_compile_action(ctx, rule_kind, output_jar, compile_jar): | |||
| dirs = _compiler_directories(ctx) | |||
| srcs = _partitioned_srcs(ctx.files.srcs) | |||
| friend = _compiler_friends(ctx, friends = getattr(ctx.attr, "friends", [])) | |||
| compile_deps = _compiler_deps(toolchains, friend, deps = ctx.attr.deps + ctx.attr.plugins) | |||
| compile_deps = _compiler_deps(toolchains, friend, deps = ctx.attr.deps) | |||
There was a problem hiding this comment.
Did this sneak in? Or is it part of the fix?
There was a problem hiding this comment.
That's the fix. Including plugins as compile deps produces the error in the PR description
jongerrish
force-pushed
the
kt_compiler_plugin_android
branch
from
bcfe057 to
720ac92
Compare
jongerrish
force-pushed
the
kt_compiler_plugin_android
branch
from
720ac92 to
53a9577
Compare
jongerrish
force-pushed
the
kt_compiler_plugin_android
branch
from
53a9577 to
1d88017
Compare
restingbull
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kt_compiler_plugincurrently doesn't work when used from anywhere in the deps of anandroid-binarytarget, failing as follows:-The fix is not including plugins as part of the compile deps.
Add
kt_compiler_pluginto thekt_android_librarytarget referenced by anandroid_binaryupdate Activity to reference generated code to validate it was run correctly.