Make kt_compiler_plugin work with android_binary

bazelbuild · Nov 12, 2020 · 53a9577 · 53a9577
1 parent 54c5ec8
commit 53a9577
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 4 deletions.
diff --git a/examples/android/WORKSPACE b/examples/android/WORKSPACE
@@ -19,6 +19,7 @@ maven_install(
         "junit:junit:4.12",
         "androidx.test.espresso:espresso-core:3.1.1",
         "org.hamcrest:hamcrest-library:1.3",
+        "org.jetbrains.kotlinx:kotlinx-serialization-runtime:1.0-M1-1.4.0-rc",
     ],
     repositories = [
         "https://jcenter.bintray.com/",

diff --git a/examples/android/lib/BUILD.bazel b/examples/android/lib/BUILD.bazel
@@ -1,4 +1,11 @@
-load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_android_library")
+load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_compiler_plugin", "kt_android_library")
+
+kt_compiler_plugin(
+    name = "serialization_plugin",
+    deps = [
+        "@com_github_jetbrains_kotlin//:kotlinx-serialization-compiler-plugin",
+    ],
+)
 
 kt_android_library(
     name = "lib",
@@ -7,6 +14,10 @@ kt_android_library(
     manifest = "src/main/AndroidManifest.xml",
     visibility = ["//visibility:public"],
     deps = [
+        "@maven//:org_jetbrains_kotlinx_kotlinx_serialization_runtime",
         "@maven//:androidx_appcompat_appcompat",
     ],
+    plugins = [
+        ":serialization_plugin",
+    ],
 )
diff --git a/examples/android/lib/src/main/kotlin/examples/android/lib/MainActivity.kt b/examples/android/lib/src/main/kotlin/examples/android/lib/MainActivity.kt
@@ -18,5 +18,7 @@ class MainActivity : Activity() {
         .setTitle("Blah")
         .setMessage("Blah blah blah?")
         .show()
+    // Ensure Serialization plugin has run and generated code correctly.
+    Data.serializer()
   }
 }
diff --git a/kotlin/internal/jvm/compile.bzl b/kotlin/internal/jvm/compile.bzl
@@ -236,7 +236,7 @@ def kt_jvm_compile_action(ctx, rule_kind, output_jar, compile_jar):
     dirs = _compiler_directories(ctx)
     srcs = _partitioned_srcs(ctx.files.srcs)
     friend = _compiler_friends(ctx, friends = getattr(ctx.attr, "friends", []))
-    compile_deps = _compiler_deps(toolchains, friend, deps = ctx.attr.deps + ctx.attr.plugins)
+    compile_deps = _compiler_deps(toolchains, friend, deps = ctx.attr.deps)
     annotation_processors = _plugin_mappers.targets_to_annotation_processors(ctx.attr.plugins + ctx.attr.deps)
     transitive_runtime_jars = _plugin_mappers.targets_to_transitive_runtime_jars(ctx.attr.plugins + ctx.attr.deps)
     plugins = ctx.attr.plugins
@@ -388,9 +388,10 @@ def _run_kt_builder_action(ctx, rule_kind, toolchains, dirs, srcs, friend, compi
         omit_if_empty = True,
     )
 
+    plugin_jars = _plugins_to_classpaths(plugins)
     args.add_all(
         "--pluginpath",
-        _plugins_to_classpaths(plugins),
+        plugin_jars,
         omit_if_empty = True,
     )
     args.add_all(
@@ -419,7 +420,7 @@ def _run_kt_builder_action(ctx, rule_kind, toolchains, dirs, srcs, friend, compi
         mnemonic = "KotlinCompile",
         inputs = depset(
             ctx.files.srcs,
-            transitive = [compile_deps.compile_jars, transitive_runtime_jars],
+            transitive = [compile_deps.compile_jars, transitive_runtime_jars, depset(plugin_jars)],
         ),
         tools = tools,
         input_manifests = input_manifests,