tests: improve the signal/noise ratio of the test logs by 63% #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the log of the tests were littered with messages from
Pillow:
2024-09-10 18:04:55 [ DEBUG] STREAM b'IHDR' 16 13 (PngImagePlugin.py:197)
2024-09-10 18:04:55 [ DEBUG] STREAM b'sBIT' 41 4 (PngImagePlugin.py:197)
2024-09-10 18:04:55 [ DEBUG] b'sBIT' 41 4 (unknown) (PngImagePlugin.py:753)
2024-09-10 18:04:55 [ DEBUG] STREAM b'pHYs' 57 9 (PngImagePlugin.py:197)
After this change, on my machine, the size of the log produced by running
"make test" goes from 1405 to 513 lines, a 63% reduction, that hopefully
increases the signal noise ratio of the test logs.
muxator
force-pushed
the
tests-logs-remove-littering-by-pillow
branch
2 times, most recently
from
cf86f1a to
8d5afd6
Compare
muxator
force-pushed
the
tests-logs-remove-littering-by-pillow
branch
from
8d5afd6 to
4c49640
Compare
|
Small changes and a big effect on test clarity, can be merged for me! |
muxator
force-pushed
the
tests-logs-remove-littering-by-pillow
branch
from
4c49640 to
9c51d6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the logs of the tests were littered with messages from Pillow:
After this change, on my machine, the size of the log produced by running "make test" goes from 1405 to 513 lines, a 63% reduction, that hopefully increases the signal noise ratio of the test logs.
This PR should be merged after #84.