Fix PytestRemovedIn8Warning ("support for nose tests is deprecated and will be removed in a future release") #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated and will be removed in a future release")
Before this change, the test log contained 37 entries like this:
PytestRemovedIn8Warning: Support for nose tests is deprecated and will be removed in a future release.
After this change, on my machine the test log shrinks from 1672 to 1405 lines
(16% less).
At some point in time, we will migrate to Pytest 8.x, and this would be an
hindrance.
A reference for the fix can be found at:
https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
Affected tests were found with:
rg "def (setup|teardown)\(" tests
muxator
force-pushed
the
fix-pytest-removed-in-8-warning
branch
from
16aeac5 to
32636e1
Compare
muxator
force-pushed
the
fix-pytest-removed-in-8-warning
branch
2 times, most recently
from
1d17a57 to
d1473a9
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 83.91% 88.52% +4.60%
==========================================
Files 32 33 +1
Lines 1716 1751 +35
==========================================
+ Hits 1440 1550 +110
+ Misses 276 201 -75 |
|
This LGTM, feel free to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the test log contained 37 entries like this:
After this change, on my machine the test log shrinks from 1672 to 1405 lines (16% less).
At some point in time, we will migrate to Pytest 8.x, and this would be an hindrance.
A reference for the fix can be found at https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose
Affected tests were found with:
rg "def (setup|teardown)\(" testsPlease merge this after #82 (migration to python 3.12).