Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SSE documentation and remove the feature flag #839

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Update SSE documentation and remove the feature flag #839

merged 4 commits into from
Apr 10, 2024

Conversation

vladem
Copy link
Contributor

@vladem vladem commented Apr 9, 2024

Description of change

Update documentation to include new SSE options, remove the feature flag.

Relevant issues: #534

Does this change impact existing behavior?

This is not a breaking change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:44 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:44 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:44 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:44 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:44 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:44 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:44 — with GitHub Actions Failure
@vladem vladem marked this pull request as ready for review April 9, 2024 10:48
@vladem vladem marked this pull request as draft April 9, 2024 10:52
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:55 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:55 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:55 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:55 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:55 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:55 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:55 — with GitHub Actions Failure
@vladem vladem mentioned this pull request Apr 9, 2024
Merged
@dannycjones dannycjones changed the title [SSE-KMS] Update documentation, remove the feature flag Update SSE documentation and remove the feature flag Apr 9, 2024
dannycjones
dannycjones requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks to the doc changes. Otherwise, LGTM.

doc/CONFIGURATION.md Outdated Show resolved Hide resolved
mountpoint-s3/Cargo.toml Show resolved Hide resolved
@dannycjones
Copy link
Contributor

I updated the title just so the eventual squash commit is consistent with previous style.

@vladem vladem had a problem deploying to PR integration tests April 9, 2024 12:22 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 12:22 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 12:22 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 12:22 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 12:22 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 12:22 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 9, 2024 12:22 — with GitHub Actions Failure
@vladem vladem marked this pull request as ready for review April 9, 2024 13:35
@vladem vladem requested a review from dannycjones April 9, 2024 13:35
dannycjones
dannycjones previously approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vladem vladem had a problem deploying to PR integration tests April 10, 2024 09:28 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 10, 2024 09:28 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 10, 2024 09:28 — with GitHub Actions Failure
@vladem vladem had a problem deploying to PR integration tests April 10, 2024 09:28 — with GitHub Actions Failure
Vladislav Volodkin and others added 3 commits April 10, 2024 10:23
Update documentation, remove the feature flag
cf47c34 
Signed-off-by: Vladislav Volodkin <[email protected]>
Remove the sse_kms feature flag from the CI
df41ca0 
Signed-off-by: Vladislav Volodkin <[email protected]>
@vladem @dannycjones
Update doc/CONFIGURATION.md
7cac5f5 
Co-authored-by: Daniel Carl Jones <[email protected]>
Signed-off-by: Volodkin Vladislav <[email protected]>
@vladem vladem had a problem deploying to PR integration tests April 10, 2024 10:24 — with GitHub Actions Failure
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:24 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:24 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:24 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:24 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:24 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:24 — with GitHub Actions Inactive
Remove the feature flag
029e8a7 
Signed-off-by: Vladislav Volodkin <[email protected]>
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:41 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:41 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:41 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:41 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:41 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:41 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 10, 2024 10:41 — with GitHub Actions Inactive
dannycjones
dannycjones approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@passaro passaro added this pull request to the merge queue Apr 10, 2024
Merged via the queue into awslabs:main with commit 8af2fb2 Apr 10, 2024
23 checks passed
@dannycjones dannycjones mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannycjones dannycjones dannycjones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladem @dannycjones @passaro