Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sse_kms feature flag from CI #840

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

vladem
Copy link
Contributor

@vladem vladem commented Apr 9, 2024

Description of change

Remove the sse_kms feature flag from the CI. This should be merged prior to #839.

Relevant issues: #534

Does this change impact existing behavior?

This is not a breaking change.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@vladem vladem had a problem deploying to PR integration tests April 9, 2024 10:55 — with GitHub Actions Failure
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 10:55 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 10:55 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 10:55 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 10:55 — with GitHub Actions Inactive
@vladem vladem marked this pull request as ready for review April 9, 2024 10:55
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 10:55 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 10:55 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 11:56 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 11:56 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 11:56 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 11:56 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 11:56 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 11:56 — with GitHub Actions Inactive
@vladem vladem temporarily deployed to PR integration tests April 9, 2024 11:56 — with GitHub Actions Inactive
@dannycjones dannycjones changed the title [SSE-KMS] Remove the sse_kms feature flag from the CI Remove sse_kms feature flag from CI Apr 9, 2024
Copy link
Contributor

@dannycjones dannycjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, to merge just ahead of #839.

@vladem vladem enabled auto-merge April 9, 2024 12:07
@vladem vladem added this pull request to the merge queue Apr 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2024
@dannycjones dannycjones added this pull request to the merge queue Apr 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 9, 2024
@dannycjones dannycjones added this pull request to the merge queue Apr 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 9, 2024
@dannycjones dannycjones added this pull request to the merge queue Apr 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2024
@vladem vladem added this pull request to the merge queue Apr 10, 2024
Merged via the queue into awslabs:main with commit cf5fc24 Apr 10, 2024
23 checks passed
@vladem vladem deleted the sse-kms-release-ci branch April 10, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants