Fix release pipeline #851
Merged
Fix release pipeline #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mv wildcard statement failed due to collisions (src and dst dir both had "deps" subfolders). Fix by being more targeted, only moving lib/ folder - Fix some s3 cp commands. --include has no effect unless you also have --exclude "*"
Apparently you're supposed to set $GOROOT if you install it somewhere arbitrary, so let's put it in the official /usr/local/go
It existed briefly in builder.json in the PR that added this line, ed809e4, but it was removed from builder.json before that PR was merged
graebm
commented
Nov 30, 2024
|
|
||
| JAVA_HOME=/usr/lib/jvm/java-11-openjdk-amd64 mvn -B package -DskipTests -Dshared-lib.skip=true -Dcrt.classifier=$CLASSIFIER | ||
|
|
||
| aws s3 cp --recursive --include "*.so" target/cmake-build/lib s3://aws-crt-java-pipeline/${GIT_TAG}/lib | ||
| aws s3 cp --recursive --exclude "*" --include "*.so" target/cmake-build/lib s3://aws-crt-java-pipeline/${GIT_TAG}/lib |
There was a problem hiding this comment.
Adding --exclude "*" because:
https://docs.aws.amazon.com/cli/latest/reference/s3/#use-of-exclude-and-include-filters
Note that, by default, all files are included. This means that providing only an --include filter will not change what files are transferred. --include will only re-include files that have been excluded from an --exclude filter. If you only want to upload files with a particular extension, you need to first exclude all files, then re-include the files with the particular extension.
This wasn't causing any bugs, but it's code that wasn't doing what it was supposed to be doing, so fixed this here (and in a few other locations)
graebm
added a commit
to awslabs/aws-c-common
that referenced
this pull request
Dec 4, 2024
**Issue:** When aws-crt-java started prebuilding AWS-LC, the release pipeline broke due to a relative path being passed to CMake (see: awslabs/aws-crt-java#851) Since the AwsPrebuildDependency changed the working directory while running CMake, the relative path became invalid. **Description of changes:** Instead of changing the working directory while running CMake, use the `-B<path-to-build>` option (which exists prior to CMake 3.13 even though it's not documented, note that it's a bit weird pre-3.13 with no space after the B))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The most recent release failed for 2 different reasons:
mv target/cmake-build/aws-crt-java/* target/cmake-build/aws-crt-java-manylinux-x64-fipsjob failed with error "Could not find Go"Description of changes:
mvon the 1 directory we care about, instead of doingmvon a wildcard where lots of stuff we don't care about can collide.go/go/bin) to$PATH(which is weird usually you add absolute paths). And broke when the new "prebuild aws-lc" logic changed the working directoryBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.