Support relative paths when prebuilding dependencies with CMake #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OT changing the working directory. Instead use the -B<path-to-build> option, which exists prior to CMake 3.13 even though it's not documented (note: it's a bit weird pre-3.13, with no space after the B)
sfod
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When aws-crt-java started prebuilding AWS-LC, the release pipeline broke due to a relative path being passed to CMake (see: awslabs/aws-crt-java#851)
Since the AwsPrebuildDependency changed the working directory while running CMake, the relative path became invalid.
Description of changes:
Instead of changing the working directory while running CMake, use the
-B<path-to-build>option (which exists prior to CMake 3.13 even though it's not documented, note that it's a bit weird pre-3.13 with no space after the B))By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.