Scale the lambda_timeout parameter correctly. #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambda_timeout in the config is in seconds, but LambdaContext wants the timeout in ms.
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
==========================================
+ Coverage 94.65% 94.66% +<.01%
==========================================
Files 18 18
Lines 3164 3167 +3
Branches 412 413 +1
==========================================
+ Hits 2995 2998 +3
Misses 118 118
Partials 51 51
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lambda_timeout in the config is in seconds, but LambdaContext wants the timeout in ms.