Fix timeouts for invocations on the command line. #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ttung
force-pushed
the
tonytung-networking
branch
from
a7f3bc6 to
713fce9
Compare
ttung
force-pushed
the
tonytung-cmdline
branch
4 times, most recently
from
79b1d78 to
609f207
Compare
|
Sorry about the delay with this review. This PR does not seem to stack correctly - it has a number of extraneous changes. Could you rebase it to stack correctly? Also, Chalice 1.0.2+ should not crash when get_remaining_time_in_millis() is called in local mode. |
ttung
force-pushed
the
tonytung-cmdline
branch
from
609f207 to
a327d34
Compare
kislyuk
requested changes
Oct 24, 2017
chalice/app.py
Outdated
| @@ -85,6 +85,8 @@ def wrapper(*args, **kwargs): | |||
| future = executor.submit(method, *args, **kwargs) | |||
| time_remaining_s = chalice_app._override_exptime_seconds # type: typing.Optional[float] | |||
| if time_remaining_s is None: | |||
| import pdb | |||
| pdb.set_trace() | |||
There was a problem hiding this comment.
One last change: please deactivate the pdb tracer :)
ttung
force-pushed
the
tonytung-cmdline
branch
from
a327d34 to
d2fda8b
Compare
ttung
force-pushed
the
tonytung-cmdline
branch
from
d2fda8b to
321f71c
Compare
kislyuk
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use the chalice app in tests, we override the timeout. When we use the chalice app on lambda, the timeout is valid.
However, in the current version of chalice we're using, calling
get_remaining_time_in_millis()throws an exception when not run in a lambda.This diff: