ES6 coverage, updated karma and jasmine dependencies

[bellstrand]

Added ES6 coverage.
The old setup showed coverage on the transpiled code which makes the coverage percentage show number that does not represent the reality and it's hard to track what you need to test.

The new setup uses babel-plugin-__coverage__ instread of isparta & istanbul.

Isparta is since 27 March unmaintained, so I think it's time to swap it out for something new.

Updated dependencies for karma & jasmine when I were at it.

Any thought on this? Feedback is always welcome!

[EisenbergEffect]

@bellstrand Would you mind rebasing on master?

[AshleyGrant]

@bellstrand just in case you haven't rebased off the upstream master before, here's a tutorial I created last year when I learned how to do this: https://www.youtube.com/watch?v=M7ZYkjOWr6g

Here's a summary:
The git commands you'll need as the fork developer are:
Add the upstream repo as a remote
git remote add upstream upstreamrepourl

Checkout your master branch:
git checkout master

Pull using rebase the upstream master branch to your fork's master branch:
git pull --rebase upstream master

Checkout your feature branch:
git checkout featurebranch

Rebase the feature branch:
git rebase master

If there are conflicting changes, git will tell you to merge any conflicting changes. Merge these changes in your text editor and then continue the rebase:
git add filename
git rebase --continue

[bellstrand]

@EisenbergEffect: I've rebased against on master now!
@AshleyGrant++;

[EisenbergEffect]

@AshleyGrant Can you review this?

[AshleyGrant]

I'll pull it down and check it out. @bellstrand would you mind updating your commit message to match our commit message guidelines. Thanks!

[AshleyGrant]

Tests and code coverage ran fine.

[AshleyGrant]

Ashley@DESKTOP-2NT3EJC MINGW64 ~/github/skeleton-navigation/skeleton-esnext ((b77c0e9...))
$ gulp test
(node:5292) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
[14:38:48] Using gulpfile ~\github\skeleton-navigation\skeleton-esnext\gulpfile.js
[14:38:48] Starting 'test'...
08 07 2016 14:38:49.715:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/
08 07 2016 14:38:49.715:INFO [launcher]: Starting browser Chrome
08 07 2016 14:38:50.981:INFO [Chrome 51.0.2704 (Windows 10 0.0.0)]: Connected on socket /#SLZPGP5jbNdm-1L-AAAA with id 91262488
Chrome 51.0.2704 (Windows 10 0.0.0): Executed 11 of 11 SUCCESS (0.022 secs / 0.005 secs)
[14:38:51] Finished 'test' after 3 s

Ashley@DESKTOP-2NT3EJC MINGW64 ~/github/skeleton-navigation/skeleton-esnext ((b77c0e9...))
$ gulp cover
(node:5076) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
[14:39:43] Using gulpfile ~\github\skeleton-navigation\skeleton-esnext\gulpfile.js
[14:39:43] Starting 'cover'...
08 07 2016 14:39:45.187:INFO [karma]: Karma v0.13.22 server started at http://localhost:9876/
08 07 2016 14:39:45.187:INFO [launcher]: Starting browser Chrome
08 07 2016 14:39:46.468:INFO [Chrome 51.0.2704 (Windows 10 0.0.0)]: Connected on socket /#MQxd-b55f-btKlQRAAAA with id 35843361
------------------|----------|----------|----------|----------|----------------|
File              |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
------------------|----------|----------|----------|----------|----------------|
 src\             |    92.86 |      100 |       75 |    92.86 |                |
  app.js          |      100 |      100 |      100 |      100 |                |
  child-router.js |      100 |      100 |      100 |      100 |                |
  users.js        |    85.71 |      100 |       75 |    85.71 |             12 |
------------------|----------|----------|----------|----------|----------------|
All files         |    92.86 |      100 |       75 |    92.86 |                |
------------------|----------|----------|----------|----------|----------------|

[14:39:46] Finished 'cover' after 3.04 s

[niieani]

This should be ported to the TypeScript JSPM skeleton before merging too.

[AshleyGrant]

The code coverage stuff uses a babel plugin. Would that even work over there?

[niieani]

Hmm. There's gotta be an alternative that also works for TypeScript in Gulp. I've got coverage working for both Babel and TypeScript in the Webpack skeletons, and it's done with the same libraries.

[AshleyGrant]

Maybe we could use that instead of this?

[niieani]

If we'd like both skeletons to be as close to each other as possible, we should probably use https://github.com/SBoudrias/gulp-istanbul together with remap-istanbul.
There's a tutorial here: https://www.sitepen.com/blog/2015/09/29/code-coverage-for-typescript-and-other-transpiled-languages/

[bellstrand]

@AshleyGrant commit message updated to follow the guidelines.
@niieani What other lib have you found that generates a coverage report that shows the source, and not the transpiled code?
@AshleyGrant Open the generated html after running cover instead of just looking at the terminal output, theres where the big difference is.

[EisenbergEffect]

@AshleyGrant @niieani Just checking to see where we are at on this.

[AshleyGrant]

I'm looking in to this currently

[EisenbergEffect]

@AshleyGrant Where are we at with this currently?

[AshleyGrant]

I was never able to get anything working for TypeScript that would run the same way as this. The webpack solution (necessarily) runs against already transpiled code.

[niieani]

@AshleyGrant @EisenbergEffect The Webpack solution simply uses source-maps and remap-istanbul to regenerate coverage based on pre-transpiled code. This is possible to implement with gulp, here's how: https://github.com/SitePen/remap-istanbul#gulp-plugin

[plwalters]

I think we should try to get this merged and create a new issue for the other skeletons if we can that way it doesn't become stale and need to rebase on anything.

[bellstrand]

@PWKad I disagree, if the way forward is with another library it's better to discard this.

Anyhow after this pull request was made babel-plugin-__coverage__ has been replaced with a "official" istanbul plugin babel-plugin-istanbul https://github.com/istanbuljs/babel-plugin-istanbul.
So if we decide that this is a good route, we should change to the new package and update the karma conf accordingly. Just give me a shout if you'd like me to fix that.

[niieani]

@bellstrand rebasing after 1.0.0 final and integrating the official plugin would be appreciated! Thanks. Seems like the JSPM TypeScript version will need a bit more love with the remap-istanbul post-processor.

[bellstrand]

@niieani I've rebased against master and swapped to the official plugin now.
Just give me a shout if there's anything more I should fix/do!

[niieani]

LGTM.
@EisenbergEffect could you ping somebody actively using JSPM that would want to give this a go?

[EisenbergEffect]

@AshleyGrant You took a look at this earlier on. Would you be able to take a look at this update?

[niieani]

We should probably merge this before it goes stale. Can anybody confirm this works properly without breaking anything?

[EisenbergEffect]

@AshleyGrant Can you review this one final time and advise? I'd like to merge this or close it in the next day.

[AshleyGrant]

Let's merge it. Just tested it. Works great.

[AshleyGrant]

@EisenbergEffect is @bellstrand good on CLA?

[niieani]

@AshleyGrant the new automated CLA checks shows that yes. See "details" in the check.