Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

TypeScript Code Coverage Task? #278

Closed
Vheissu opened this issue Jan 29, 2016 · 13 comments
Closed

TypeScript Code Coverage Task? #278

Vheissu opened this issue Jan 29, 2016 · 13 comments

Comments

@Vheissu
Copy link
Member

Vheissu commented Jan 29, 2016

Are there any plans to implement code coverage in the Aurelia TypeScript Skeleton like there is in the standard ES Skeleton? I ask because there is the isparta dependency in the package,json, but it is not being used. I would love to implement code coverage into my app, but not sure where TypeScript falls into this. I know testing was a pain to get working in the first place.

@Vheissu Vheissu changed the title TypeScript Code Coverage TypeScript Code Coverage Task? Jan 29, 2016
@Vheissu Vheissu closed this as completed Jun 24, 2016
@bfil
Copy link
Contributor

bfil commented Jun 24, 2016

Has this actually been implemented in the TypeScript skeleton?

@niieani
Copy link
Contributor

niieani commented Jun 24, 2016

Yes, in both the Webpack skeletons. There's a pull request open regarding
JSPM.
On Fri, 24 Jun 2016 at 09:23, Bruno Filippone [email protected]
wrote:

Has this been actually implemented in the TypeScript skeleton?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#278 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAiZDdTPH9d9l7apJ5_34dCAsU-p0FeOks5qO4XXgaJpZM4HO3ab
.

@bfil
Copy link
Contributor

bfil commented Jun 24, 2016

@niieani looks like the PR is for esnext not typescript

@AshleyGrant
Copy link
Collaborator

I'm gonna look in to this today

@Vheissu
Copy link
Member Author

Vheissu commented Jul 12, 2016

@AshleyGrant I'll talk to you in the Gitter chat, but I have some work here which might help adding in coverage to the Karma testing.

@Roustalski
Copy link

Hey guys. Any headway here? Is there a branch somewhere that might have some work completed already that we can leech off of?

@niieani
Copy link
Contributor

niieani commented Aug 6, 2016

There's a discussion here, re. the parallel ESNext support: #519.
We're open to pull requests for TS support, I've explained how it could be implemented in the discussion of the above pull (istanbul-remap).

@Roustalski
Copy link

I was able to get coverage working of my typescript files using the Aurelia CLI, but have run into an issue: http://stackoverflow.com/questions/39650904/how-do-i-get-the-aurelia-cli-to-provide-a-stack-trace-on-a-gulp-plugin-error

@bfil
Copy link
Contributor

bfil commented Oct 1, 2016

@Roustalski I've tried to clone your repo but it spits out an empty coverage for me..

It seems like karma-systemjs complicates things quite a bit, and I'm unable to get the coverage working in any way using it together with other karma plugins such as karma-coverage and karma-remap-istanbul.

The ESNext skeleton uses karma-jspm, is this supposed to use that instead?

@niieani can you elaborate on how you would plan to use gulp-istanbul?

@Alexander-Taran
Copy link

Stale since 2016

@mttmccb
Copy link

mttmccb commented Mar 9, 2018

@Alexander-Taran I've tried a few times to get this working with my project and failed, last time I got an error similar to this repro.

Somewhat related from the CLI repo.

@Alexander-Taran
Copy link

Thanks @mttmccb

@chrsmrtn-
Copy link

I too have run into this issue when updating from 0.33.1 to 0.35.1. I use typescript as well

@bigopon bigopon closed this as completed Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants