This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
Rollup #238
Open
aminya
wants to merge
53
commits into
atom:master
Choose a base branch
from
aminya:rollup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rollup #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decaffeinate . --use-js-modules --loose decaffeinate . --modernize-js Get-ChildItem *.coffee -Recurse | foreach { Remove-Item -Path $_.FullName }
Now that we have babel we can use optional chaining
Make formatting like the original code
Make the formatting like the original code
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready
Only last three commits are for this pull request. This adds rollup on top of #236
Description of the Change
Rollup: bundle the package using rollup
How to review?
Tests are untouched to show full functionality and backward compatibility. ✔️
Benefits
Possible Drawbacks
Applicable Issues