Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup #3

Merged
merged 7 commits into from
Aug 29, 2020
Merged

Rollup #3

merged 7 commits into from
Aug 29, 2020

Conversation

aminya
Copy link
Owner

@aminya aminya commented Aug 29, 2020

Ready

Only last three commits are for this pull request. This adds rollup on top of atom#236

Description of the Change

Rollup: bundle the package using rollup

How to review?

Tests are untouched to show full functionality and backward compatibility. ✔️

Benefits

  • Faster loading time because of using JavaScript and Rollup.

Possible Drawbacks

Applicable Issues

@aminya aminya merged commit 0deb6aa into master Aug 29, 2020
@aminya
Copy link
Owner Author

aminya commented Aug 29, 2020

Already upstreamed atom#238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant