Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google-protobuf to v4.27 #122

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Bump google-protobuf to v4.27 #122

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64273c0
Bump `google-protobuf` to v4.27
cocoahero Jul 12, 2024
4c7148b
Update tests to use `4.x` syntax.
cocoahero Jul 12, 2024
b1a0871
Update twirp.gemspec
cocoahero Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions test/fake_services.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,8 @@

# Protobuf messages.
# An example of the result of the protoc ruby code generator.
Google::Protobuf::DescriptorPool.generated_pool.build do
add_message "example.Size" do
optional :inches, :int32, 1
end
add_message "example.Hat" do
optional :inches, :int32, 1
optional :color, :string, 2
end
add_message "example.Empty" do
end
end
descriptor_data = "\n\ntest.proto\x12\x07\x65xample\"\x16\n\x04Size\x12\x0e\n\x06inches\x18\x01 \x01(\x05\"$\n\x03Hat\x12\x0e\n\x06inches\x18\x01 \x01(\x05\x12\r\n\x05\x63olor\x18\x02 \x01(\t\"\x07\n\x05\x45mptyb\x06proto3"
Google::Protobuf::DescriptorPool.generated_pool.add_serialized_file(descriptor_data)

module Example
Size = Google::Protobuf::DescriptorPool.generated_pool.lookup("example.Size").msgclass
Expand Down Expand Up @@ -56,11 +47,9 @@ class EmptyClient < Twirp::Client
end

# Foo message
Google::Protobuf::DescriptorPool.generated_pool.build do
add_message "Foo" do
optional :foo, :string, 1
end
end
descriptor_data = "\n\tfoo.proto\"\x12\n\x03\x46oo\x12\x0b\n\x03\x66oo\x18\x01 \x01(\tb\x06proto3"
Google::Protobuf::DescriptorPool.generated_pool.add_serialized_file(descriptor_data)

Foo = Google::Protobuf::DescriptorPool.generated_pool.lookup("Foo").msgclass

# Foo Client
Expand Down
2 changes: 1 addition & 1 deletion twirp.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.required_ruby_version = '>= 1.9'
spec.add_runtime_dependency 'google-protobuf', '~> 3.0', '>= 3.7.0'
cocoahero marked this conversation as resolved.
Show resolved Hide resolved
spec.add_runtime_dependency 'google-protobuf', '>= 3.7.0', '< 5'
cocoahero marked this conversation as resolved.
Show resolved Hide resolved
spec.add_runtime_dependency 'faraday', '< 3' # for clients
spec.add_dependency 'rack', '>= 2.2.3' # for service server handling

Expand Down