Bump google-protobuf to v4.27
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurnn
reviewed
Jul 12, 2024
cocoahero
force-pushed
the
bump-protobuf-4
branch
from
1f45d86 to
4c7148b
Compare
Co-authored-by: Colin Bendell <[email protected]>
colinbendell
approved these changes
Jul 15, 2024
|
Would be awesome to get this landed so we can use Thanks @cocoahero for the PR! |
This was referenced Aug 26, 2024
Closed
dpep
added a commit
to dpep/rspec-twirp
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gem currently has a version lock on
google-protobufthat prevents users from migrating to the4.xseries of versions. This prevents us from upgrading ourprotocversion beyond v25, which includes needed support for service custom options, etc.There shouldn't be any issues with supporting both
3.xand4.xeven though the code thatprotocgenerates is not backwards compatible. Alltwirpcurrently cares about is that the types exist.