Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node:punycode usage by using a fork of fast-url-parser #990

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

kamilkisiela
Copy link
Collaborator

@kamilkisiela kamilkisiela commented Dec 5, 2023

Copy link
Contributor

github-actions bot commented Dec 5, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@whatwg-node/node-fetch 0.5.2-alpha-20231205155646-a4f0d0a42c7d0cd74d5443e8062e8f137082900e npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Dec 5, 2023

✅ Benchmark Results

     ✓ no-errors
     ✓ expected-result

     checks.........................: 100.00% ✓ 292178     ✗ 0     
     data_received..................: 29 MB   959 kB/s
     data_sent......................: 12 MB   390 kB/s
     http_req_blocked...............: avg=1.36µs   min=892ns    med=1.19µs   max=173.05µs p(90)=1.85µs   p(95)=2µs     
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=121.57µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=143.86µs min=96.76µs  med=137.86µs max=12.81ms  p(90)=159.28µs p(95)=165.83µs
       { expected_response:true }...: avg=143.86µs min=96.76µs  med=137.86µs max=12.81ms  p(90)=159.28µs p(95)=165.83µs
     http_req_failed................: 0.00%   ✓ 0          ✗ 146089
     http_req_receiving.............: avg=24.29µs  min=12.59µs  med=23.11µs  max=3.75ms   p(90)=30.11µs  p(95)=32.05µs 
     http_req_sending...............: avg=6.31µs   min=4.12µs   med=5.57µs   max=4.17ms   p(90)=8.06µs   p(95)=8.59µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=113.24µs min=70.52µs  med=106.91µs max=8.55ms   p(90)=125.01µs p(95)=130.29µs
     http_reqs......................: 146089  4869.45591/s
     iteration_duration.............: avg=201.04µs min=144.21µs med=194.35µs max=12.96ms  p(90)=218.37µs p(95)=226.8µs 
     iterations.....................: 146089  4869.45591/s
     vus............................: 1       min=1        max=1   
     vus_max........................: 1       min=1        max=1   

@ardatan ardatan merged commit c6806ff into master Dec 8, 2023
@kamilkisiela kamilkisiela deleted the kamil-fast-url-parser-fork branch December 8, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants